We have the requirement that modifying yaml belonging to the user must preserve their comments, since the output may still be read by humans. There is no existing library for Go which supports this behaviour, and as a result we manipulate yaml with a collection of regular expressions in cluster/kubernetes/update.go and cluster/kubernetes/policies.go.
This code is difficult to maintain, changes to it are difficult to review, and it's difficult to be sure it does the right thing for all possible inputs.
We should delete it all and offload the yaml-modification to kubeyaml, as is being done in #976.
samb1729
All 5 comments
As of #976 being merged, we don't modify YAMLs from the go code any more.
squaremo
on 5 Jun 2018
Awesome!
samb1729
on 5 Jun 2018
For the record: https://github.com/weaveworks/flux/issues/1120
squaremo
on 5 Jun 2018
No help wanted labels in sight
samb1729
on 5 Jun 2018
No help wanted labels in sight
Magic labeling machine waved!
squaremo
on 5 Jun 2018
Related issues
alexhumphreys
路
4Comments
IsNull
路
4Comments
javefang
路
4Comments
Alphapage
路
3Comments
eimarfandino
路
3Comments
Most helpful comment
Awesome!