Flutter-permission-handler: iOS notification permission request returns wrong results.

[marcelderkskarlmax]

🐛 Bug Report

When you start a permission request for notifications on iOS there are two problems.

1. The result is returned before the user has actually answered the system permission dialog.
2. The resulting permission status for that permission group is always granted.

Expected behavior

The permission request should wait until the user has answered the system permission dialog and then give the correct permission granted / denied based on users decision.

Additional notes

I already had a look into the method requestPermission of the NotificationPermissionStrategy class and found that the completion block of the requestAuthorizationWithOptions call only handles the PermissionStatusDenied case. Instead of sending the PermissionStatusGranted from inside the result block it is sent at the end of the method. Which means it does not wait for the user to finish its input.

- (void)requestPermission:(PermissionGroup)permission completionHandler:(PermissionStatusHandler)completionHandler {
  PermissionStatus status = [self checkPermissionStatus:permission];
  if (status != PermissionStatusUnknown) {
    completionHandler(status);
    return;
  }
  dispatch_async(dispatch_get_main_queue(), ^{
    if(@available(iOS 10.0, *)) {
      UNUserNotificationCenter *center = [UNUserNotificationCenter currentNotificationCenter];
      UNAuthorizationOptions authorizationOptions = 0;
      authorizationOptions += UNAuthorizationOptionSound;
      authorizationOptions += UNAuthorizationOptionAlert;
      authorizationOptions += UNAuthorizationOptionBadge;
      [center requestAuthorizationWithOptions:(authorizationOptions) completionHandler:^(BOOL granted, NSError * _Nullable error) {
        if (!granted || error != nil) {
          completionHandler(PermissionStatusDenied);
          return;
        }
      }];
    } else {
      UIUserNotificationType notificationTypes = 0;
      notificationTypes |= UIUserNotificationTypeSound;
      notificationTypes |= UIUserNotificationTypeAlert;
      notificationTypes |= UIUserNotificationTypeBadge;
      UIUserNotificationSettings *settings = [UIUserNotificationSettings settingsForTypes:notificationTypes categories:nil];
      [[UIApplication sharedApplication] registerUserNotificationSettings:settings];
    }

// I think this code belongs into the authorisation requests completion handler.
    [[UIApplication sharedApplication] registerForRemoteNotifications];
    completionHandler(PermissionStatusGranted);
  });
}

Version: 4.0
Platform:

• [X ] :iphone: iOS 12+
• [ ] :robot: Android

[edblokcer]

I'm having the exact same issue

[officialkimp]

I'm having the exact same issue.

[njovy]

Any new updates regarding this issue? This still happens to the latest version.

[mitesh77]

I am testing 5.0.0+hotfix.3, it has the same issue. request returns wrong results on android(not sure in ios).
I this dependency last some update is not good for any project and also unstable.

[danielroek]

I'm not able to reproduce this with Flutter 1.20.3 and permission_handler 5.0.1+1. If this, or a different, issue occurs, please submit a new issue.