Fluentui: Address circular dependencies in examples
(from @ecraig12345 )
In a component's examples, it's common to use other components to help control the examples or demonstrate concepts. This worked fine when all the components were in the same package, but it will cause problems once we split the components into separate packages.
Currently the new react-* component packages such as react-button get around this by depending on OUFR rather than @fluentui/react-next, but that hack will no longer work once OUFR and @fluentui/react-next merge into @fluentui/react.
One possible fix is finishing the move to packages/examples, which I (Elizabeth) introduced earlier this year in #11984 to get around this issue. The idea is that each package's examples (and doc .md files) can live under paths like packages/examples/src/<package-name>/components/<Whatever>, and each package will have its own separate storybook to ensure start times stay reasonable. I even wrote a script to copy existing examples (still slightly buggy), but ran into some issues with build and had to move on to other things. But it should be possible to finish.
Since merging OUFR and react-next will happen in the beta prep period, we should probably get work on the circular dependency issue underway before then so that we don't get block if it takes longer than expected.
JustSlone
All 26 comments
@khmakoto @joschect we filed this issue to track the work to address circular dependencies in the examples. Please fill out the issue body as you figure out this work.
JustSlone
on 21 Aug 2020
I filled out the issue body with more details just now (somehow before seeing Justin's comment) with the background and plan I have in mind. @khmakoto and @joschect, let me know if anything is unclear, and of course feel free to edit the issue further with your own thoughts.
ecraig12345
on 21 Aug 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as [email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @uifabric/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
:tada:This issue was addressed in #15132, which has now been successfully released as @fluentui/[email protected].:tada:
Handy links:
msft-github-bot
on 27 Sep 2020
Related issues
satbai
路
3Comments
carruthe
路
3Comments
luisrudge
路
3Comments
holysnake91
路
3Comments
justinwilaby
路
3Comments
Most helpful comment
I filled out the issue body with more details just now (somehow before seeing Justin's comment) with the background and plan I have in mind. @khmakoto and @joschect, let me know if anything is unclear, and of course feel free to edit the issue further with your own thoughts.