Fluentui: Background color removed on ChoiceGroup when disabled

Created on 22 Mar 2020  ·  3Comments  ·  Source: microsoft/fluentui

ChoiceGroup Author Feedback Question ❔

All 3 comments

@Puyush6889 If you look at "git blame" you can see that it was removed in this PR: https://github.com/microsoft/fluentui/commit/c83add9cbc62c6530f2a9afd06fad57297473b40 by @Vitalius1 - looks like it was removed among bulk style adjustments a year ago - the PR description doesn't say anything else but maybe Vitalie can provide further context.

This was a part of the fluentization process for the Fabric 7 so this was definitely an intentional change. A quick look at the line that was linked the change was to follow the design specs for fluent looks of the control (when a choice is checked but at the same time is disabled). Below are some screenshots to how it was before (Fabric 6 MDL2 styling) and after (Fabric 7 fluent styling)

Before

choice_non_fluent
# After
choice_fluent

In fabric 6 the the disabled and checked state was treated to be same. So when a checkbox was disabled it would be marked out gray.
image

After syncing with @Vitalius1, fabric 7 they keep track of the state so when it's disabled the circle is changed to disabled state as shown in the picture
image

Was this page helpful?
0 / 5 - 0 ratings