Fluentui: Bug: flexBasis with Number disappears

Created on 2 Nov 2019  路  7Comments  路  Source: microsoft/fluentui

Using flexBasis with a Number doesn't throw an error, but it also doesn't show up in the output. It should default to pixels, like height and padding.

styling Fixed Type

Most helpful comment

Since flex-basis was doing nothing for these components, we should just remove it from them altogether.

All 7 comments

I see flex-basis is explicitly excluded in provideUnits.ts. I checked with @dzearing to see if there are any subtle regressions to removing flex-basis from this list, but we can't think of any. The fix is easy enough.

One possible styling regression is that a couple of components were using numbers (like PeoplePicker.) These currently have no effect but will take effect when flex-basis gets a default unit. I will check these components for styling regressions when doing the fix.

Since flex-basis was doing nothing for these components, we should just remove it from them altogether.

:tada:This issue was addressed in #11069, which has now been successfully released as @uifabric/[email protected].:tada:

Handy links:

:tada:This issue was addressed in #11069, which has now been successfully released as @uifabric/[email protected].:tada:

Handy links:

:tada:This issue was addressed in #11069, which has now been successfully released as [email protected].:tada:

Handy links:

:tada:This issue was addressed in #11069, which has now been successfully released as @uifabric/[email protected].:tada:

Handy links:

Was this page helpful?
0 / 5 - 0 ratings