I would like to add an underlined and borderless version of the Dropdown component
No
We are building out a form with basic inputs. We use the underlined and borderless TextField for text input like name and email. For country and DoB, we use the Dropdown component. However, we try to match the design between the two inputs but Dropdown doesn't have an underlined and borderless variant.
Underlined and borderless TextField:
Underlined and borderless Dropdown:
If the dev team doesn't see any problem of adding a new variant to the Dropdown. I'm more than happy to start a PR to add it in.
Hi @step-lee, thanks for filing this issue! I wonder if this really should be a variant or the Dropdown
that we should add to Fabric or if this scenario is simply a matter of styling that maybe would be better if you hosted it inside your app. Wonder what @joschect thinks about this.
Hello @khmakoto. Thank you for responding so quickly. To me it's a matter of consistency and feature parity:
I had an offline conversation with @joschect and we decided that we're putting this feature in the backlog for now while we work on more pressing issues.
@khmakoto I'm more than happy to start a PR to drive this new feature to take some burden off the fabric dev team. Are there any concern or "got you" I should talk to the team before coding?
Well, the biggest thing is that there was a refactor planned for the ComboBox
/Dropdown
components so we need to marry how this fits into that work and if it's even worth doing the work now. You should probably speak with @joschect about this since he is the owner of this component.
@step-lee This should all be styling and there shouldn't be any big concerns, especially since it will be an opt-in. Only challenge that I can really is that then combobox will be the odd one out. We might want to make another issue to style it similarly to keep it consistent.
Also @step-lee thanks for offering to put the fix in!
@step-lee , we had a similar feature request #11345. Could you pls give a update on your progress so far? or whether you are actively working on this?
@joschect @khmakoto, FYI - #11345 is asking for having both Dropdown and ComboBox to support underlined
@xugao I got caught up with other projects and didn't get a chance to work on this further. I'll prob try to submit a PR by the end of the week.
@step-lee - is this still working in progress ? :)
I think that the design of ComboBox and Dropdown components should be based on a TextField, similarly DatePicker.
@step-lee Any updates on this one?
@joschect First time contributing. Please let me know if I need to fix my PR.
Most helpful comment
Hello @khmakoto. Thank you for responding so quickly. To me it's a matter of consistency and feature parity:
Above are the reasoning for my proposal. However, I understand this also touches design language. I'm more than happy to provide more reason.