Fluentui: Disable items in <Nav /> component

Created on 29 Jan 2019  路  9Comments  路  Source: microsoft/fluentui

Add please in

Backlog review Feature

Most helpful comment

Spoke to @betrue-final-final offline about this request, and we agree that it sounds reasonable! I'll try to create a PR with the changes today or tomorrow.

All 9 comments

This sounds like a reasonable ask to me! @betrue-final-final what do you think? Have we thought about allowing links in a Nav to be disabled?

The implementation seems to be a <button />. If that's the case, then I think this request makes sense. Perhaps another use-case for getNativeProps if it'll solve similar cases. Only glanced at the source though.

Still worth getting consensus from others!

Spoke to @betrue-final-final offline about this request, and we agree that it sounds reasonable! I'll try to create a PR with the changes today or tomorrow.

Sorry for the delay here! We originally anticipated this addition would be quick and easy, but it involves a little more work with the styling, since Nav links override button styling and the disabled button styling is what we'd want to use.

Since this work involves more in-depth discussion of the styling for several different types of links within a Nav, to make sure it gets the time and attention it needs and deserves, I'm going to add this to the backlog. Thanks for your patience here!

@natalieethell Hi, how is going ? :)

@Koniksan Hey thanks for checking in! Since this is now in backlog review, @micahgodbolt and @dzearing would know more about the status. Have we gotten a chance to review this feature request yet?

@natalieethell Hey, we glad to contribute to the office ui fabric! I hope my PR help all of us with this issue :)

:tada:This issue was addressed in #8120, which has now been successfully released as [email protected].:tada:

Handy links:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rickyp-ms picture rickyp-ms  路  3Comments

mattcoxonline picture mattcoxonline  路  3Comments

carruthe picture carruthe  路  3Comments

luisrudge picture luisrudge  路  3Comments

justinwilaby picture justinwilaby  路  3Comments