Fluentui: ExtendedPeoplePicker should pass in autocorrect=off and spellcheck=false to Autofill as native props

Created on 25 Sep 2018  路  13Comments  路  Source: microsoft/fluentui

Please provide a reproduction of the bug in a codepen:


Bug Report

  • __Package version(s)__: (fill this out)
  • __Browser and OS versions__: (fill this out if relevant)

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Requested priority: (Blocking, High, Normal, Low)

Products/sites affected: (if applicable)

Describe the issue:

image

[spoke with Francis in person]

Actual behavior:

Expected behavior:

Pickers Good First Issue 馃弳

All 13 comments

@philipzloh Is the issue that you can not pass them at all through inputProps prop as in https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/office-ui-fabric-react/src/components/ExtendedPicker/BaseExtendedPicker.types.ts#L86 or the issue is they are not passed as native props so they are not working?

@philipzloh ping

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

@philipzloh to prevent this issue from closing automatically could you make it more clear if the issue is that you can not use the attributes you mentioned? After a surface investigation only spellCheck is already a part of inputProps. Are you having issues with using them both or only the autoCorrect which is not present at the moment as a native prop?

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fabric React!

The code owner is aware of the requirements; the desire is for ExtendedPeoplePicker to set these by default because ExtendedPeoplePicker is used to pick people

@philipzloh can you mention the code owner's name to ping him about the issue? Thanks!

@FrancisMengx

Hey @philipzloh, I'm going to label this good first issue since it seems like it would be relatively straightforward.

If I am interpreting this thread correctly, @FrancisMengx is the code owner and he is aware of this problem and desires to have it fixed.

Hi, I'd like to provide a patch for this.

By "should pass in autocorrect=off and spellcheck=false to Autofill" does that mean that ExtendedPeoplePicker should override autoCorrect and spellCheck regardless of what's being passed in with inputProps?

ExtendedPeoplePicker is meant to pick "people". Spellchecking/autocorrecting names here is probably never a good thing. @aleury

@aleury @Vitalius1
I think we should actually have spellCheck and autoCorrect defaults to false for BasePicker, should it?

:tada:This issue was addressed in #7301, which has now been successfully released as [email protected].:tada:

Handy Links:

Was this page helpful?
0 / 5 - 0 ratings