Fluentui: Panel: no longer outputs ms-Panel--custom

Created on 21 Sep 2018  路  7Comments  路  Source: microsoft/fluentui

Bug Report

  • __Package version(s)__: Fabric 6

Priorities and help requested:

Are you willing to submit a PR to fix? No

Requested priority: Normal

Products/sites affected: SharePoint

Describe the issue:

The Panel no longer outputs ms-Panel--custom. This seems to have occurred when it was converted to CSS-in-JS in #5823 . The code does have it under GlobalClassNames but it's never actually referenced anywhere.

Panel Type

Most helpful comment

@KevinTCoughlin you're like greased lightning! Quickest fix in the west!

All 7 comments

@oengusmacinog FYI

@Jahnp

Thanks for reporting this @phkuo. @leddie24 is this something you'd be able to look at as part of shield?

@KevinTCoughlin you're like greased lightning! Quickest fix in the west!

Great job @KevinTCoughlin. It would be good though to fix the underlying issue where this classname is not captured in snapshot and hence the regression wasn't caught...

cc @dagoff

Great job @KevinTCoughlin. It would be good though to fix the underlying issue where this classname is not captured in snapshot and hence the regression wasn't caught...

cc @dagoff

Great point! I will do that shortly 馃憤

:tada:This issue was addressed in #6450, which has now been successfully released as [email protected].:tada:

Handy Links:

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nekoya picture nekoya  路  3Comments

prashkan picture prashkan  路  3Comments

carruthe picture carruthe  路  3Comments

VincentBailly picture VincentBailly  路  3Comments

justinwilaby picture justinwilaby  路  3Comments