Fluentui: Divider custom example does not load in AMD

Created on 28 Jul 2018  路  7Comments  路  Source: microsoft/fluentui

Bug Report

  • __Package version(s)__: 6.41.0
  • __Browser and OS versions__:

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No) No

Requested priority: (Blocking, High, Normal, Low) Normal

Products/sites affected: (if applicable)

Describe the issue:

The Divider custom example does not load when loaded as an AMD module with require.js.

The Divider import in VerticalDivider.Custom.Example should be:
import { VerticalDivider, IVerticalDividerClassNames } from 'office-ui-fabric-react/lib/Divider';

Actual behavior:

Uncaught JavaScript error thrown by require.js:

  • Uncaught Error: Script error for "office-ui-fabric-react/lib/components/Divider", needed by: office-ui-fabric-react/lib/components/Divider/examples/VerticalDivider.Custom.Example

Expected behavior:

The example should load and render correctly.

If applicable, please provide a repro:

````html












All 7 comments

There is a similar issue with the DetailsList import in DetailsList.Shimmer.Example. It should be:
import { DetailsListLayoutMode, IColumn } from 'office-ui-fabric-react/lib/DetailsList';

joechung-msft picture joechung-msft on 28 Jul 2018

@JasonGore I could take a closer look but is this and this class of issues fixed with your checkin?

cliffkoh picture cliffkoh on 31 Jul 2018

Hmm it is still broken in master :\

cliffkoh picture cliffkoh on 31 Jul 2018

Co-assigning to @JasonGore because he has done a deep investigation of this today. Jason, please feel free to let us know if you will not have cycles to look into it.

cliffkoh picture cliffkoh on 31 Jul 2018

This is a separate class of issue (or feature.) I only addressed import statement regex matching issues. It looks like the script is currently written to only check relative paths, not absolute paths like package imports, so it doesn't find this class of issue.

JasonGore picture JasonGore on 31 Jul 2018
👍1

I will take this bug off @natalieethell.

cliffkoh picture cliffkoh on 31 Jul 2018

@joechung-msft fixed in #5790. Thanks for reporting.

cliffkoh picture cliffkoh on 3 Aug 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rickyp-ms picture rickyp-ms  路  3Comments
carruthe picture carruthe  路  3Comments
holysnake91 picture holysnake91  路  3Comments
satbai picture satbai  路  3Comments
prashkan picture prashkan  路  3Comments