Fluentui: [Documentation][CommandBar] Missing scss file in Fabric React with customized rendered items

Created on 30 Aug 2017  路  4Comments  路  Source: microsoft/fluentui

Describe the issue:

The CommandBar example in Fabric React refers to a file import styles = require('./CommandBar.Example.scss');. . . but

But does not provide the file to the developer or an example of the how this .scss could be constructed.

I've found the .scss file here I think and request it be included in the docs for the CommandBar example with customized renderred items in Fabric React.

Bug Report

  • __Package version(s)__:
"dependencies": {
    "@types/react": "^16.0.5",
    "@types/react-dom": "^15.5.4",
    "office-ui-fabric-react": "^4.37.6",
    "react": "^15.6.1",
    "react-dom": "^15.6.1",
    "react-scripts": "1.0.12"
  },

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Documentation No Recent Activity

Most helpful comment

The current commandBar is going to be replaced shortly, and does not use additional external CSS for the example.

In general, example css is just use to pretty up the examples, and should never be required for actual production use.

And in a case where we're showing customization, we shouldn't have those styles in an external file.

All 4 comments

I think that once we've published merge-styles, we will convert the examples to use styling via javascript and they can get included with the samples.

Another alternative is that we're working on codepen hosting for the examples. That would allow the examples to include code/css/html.

The current commandBar is going to be replaced shortly, and does not use additional external CSS for the example.

In general, example css is just use to pretty up the examples, and should never be required for actual production use.

And in a case where we're showing customization, we shouldn't have those styles in an external file.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Fabric React!

This issue has been automatically closed because it has not had recent activity after being marked as stale. If you belive this issue is still a problem or should be reopened, please reopen it! Thank you for your contributions to Fabric React!
Why am I receiving this notification?

Was this page helpful?
0 / 5 - 0 ratings