Fluentui: Icon delete is not shown on Callout buttons

Created on 13 Jul 2017  路  5Comments  路  Source: microsoft/fluentui

Bug Report

  • __Package version(s)__: 4.14.0, 4.19.0
  • __Browser and OS versions__: Chrome

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? (Yes, No)
No
Requested priority: (Blocking, High, Normal, Low)
Normal
Products/sites affected: (if applicable)
All

Describe the issue:

The icon='Delete' is not shown when you have a button in a Callout. icon='Brightness' works as expected

Actual behavior:

Got office-ui-fabric-react/src/components/Callout/examples/Callout.Cover.Example.tsx.
On line 110 after text='Click to dismiss' add the icon property and set it to Birghtness, notice that the brightness icon is properly shown on the UI.

Set the icon to Delete, no icon is shown

Expected behavior:

The Delete icon should be shown on the Button. This reproduces on menu items as well as inside a table.

If applicable, please provide a codepen repro:

Type

Most helpful comment

I've found the same isue in all kind of buttons it seems that someone changed the icon name and nobody updated the docs nor the site :( , if I use "Trash" the correct icon appears.

Here is a repro:

https://codepen.io/Intnovaction/pen/Ngmodg

* The "doc" identifies the icon as "Delete" *
https://dev.office.com/fabric#/styles/icons

All 5 comments

I've found the same isue in all kind of buttons it seems that someone changed the icon name and nobody updated the docs nor the site :( , if I use "Trash" the correct icon appears.

Here is a repro:

https://codepen.io/Intnovaction/pen/Ngmodg

* The "doc" identifies the icon as "Delete" *
https://dev.office.com/fabric#/styles/icons

This is a known issue at the moment. Currently both Delete/Trash and Switch/Switcher are both not matching the icon names on the documentation site.

It seems these are also not consistent:

  • BoxAdditionSolid
  • BoxCheckmarkSolid
  • BoxMultiplySolid
  • BoxPlaySolid
  • BoxSubtractSolid
  • CircleAdditionSolid

There are bound to be more - this should not be checked by hand (I also haven't managed to find their corresponding icons in IconCodes.ts).

Is it useful to continue collating inconsistencies? My latest was:

  • QueryList

Icons are now in a separate package which should provide consistency, please reopen if any issues remain

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ryancole picture ryancole  路  39Comments

ryancole picture ryancole  路  39Comments

just-joshing picture just-joshing  路  35Comments

quanglefed picture quanglefed  路  33Comments

JoshuaKGoldberg picture JoshuaKGoldberg  路  33Comments