Fluent-bit: [RFC] we have two upcoming out_syslog plugins

Created on 12 Oct 2019  路  6Comments  路  Source: fluent/fluent-bit

RFC

@manuelluis @ginobiliwang,

first of all thanks for your contribution!

Since two pull requests providing a similar feature has arrived: syslog output plugin, I would like to get for your feedback and input on this matter.

I would like also to ask our community for feedback about the way to proceed; this is not about which PR wins, is about if both are right and both cover the expected features. Should we merge them ?, should we focus on just one ?

please go ahead and write your comments :)

Most helpful comment

I think you should focus on https://github.com/fluent/fluent-bit/pull/1601. I think the configuration setup is much better for that interface. Both the ability to specify which tags go into which syslog field, as well as the ability to set structured data and rfc5424 I think are vital to the success of such a plugin.

All 6 comments

Excellent, it is a good opportunity for me to participate the community discussion.

I haven't looked too deeply two implementations, but by default out_syslog should output same what in_syslog inputs (like seen in parsers "syslog-rfc5424"(default?),"syslog-rfc3164-local","syslog-rfc3164"). JSON etc output should be extra/optional feature.

I think you should focus on https://github.com/fluent/fluent-bit/pull/1601. I think the configuration setup is much better for that interface. Both the ability to specify which tags go into which syslog field, as well as the ability to set structured data and rfc5424 I think are vital to the success of such a plugin.

Echoing @Benjamintf1 #1601 looks the most polished and flexible for a remote syslog target.

@edsiper do you have any rough timeline or threshold for community feedback before one of these (ideally #1601) could be merged? Asking because at the moment the only way to output to upstream syslog servers is to first forward from fluent bit to a fluentd instance... which is a little cumbersome.

I did a review of both plugins.

Based on community feedback, features and general API usage (Fluent Bit API), we would stay with #1601 .

While that PR will be merged, there is still more work on it to do like optional JSON formatting, we should discuss that based on use case and community needs.

Thanks everybody for your time on this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Barbazoo picture Barbazoo  路  3Comments

c0ze picture c0ze  路  3Comments

jcdauchy-moodys picture jcdauchy-moodys  路  3Comments

edsiper picture edsiper  路  4Comments

mbelchin picture mbelchin  路  3Comments