Flower: discussion: Potential code quality issues found

Created on 21 Jul 2020  路  3Comments  路  Source: mher/flower

I have forked this repo around a week ago and was going through the code. There I decided to run a static analysis by DeepSouce. In that analysis, I have found somewhat around 80 code quality issues in flower.

Those issues are categorized as:

  • Antipatterns: 47
  • Bug-risks: 13
  • Performance issues: 18
  • Security issues: 2

You can find the full report here → https://deepsource.io/gh/pnijhara/flower/issues/?category=recommended
Many of them can be autofixed by DeepSource in a single click such as usage of unnecessary literal which can be fixed by using literal syntax.

I would love to send a patch with some fix if you want. Also do let me know which of them you consider as false positives and which of them of high priority.

False positives or intentional violations can also be silenced by ignoring issues.

I have also added a config file as .deepsouce.toml for letting DeepSource run the analysis. You can find that file here in my forked repo.

picture pnijhara

Most helpful comment

Sure! I will send PRs for the above issues in the coming days.

picture pnijhara on 22 Jul 2020
👍2

All 3 comments

Thanks for running the analysis. Most of the issues mentioned in the report are false positives, except

Feel free to open a pull request for the issues above

mher picture mher on 22 Jul 2020
👍1

Sure! I will send PRs for the above issues in the coming days.

pnijhara picture pnijhara on 22 Jul 2020
👍2

@mher only one of the above-stated issue has been solved. Moreover, I would love to integrate DeepSource with flower.

pnijhara picture pnijhara on 18 Aug 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

arnpow picture arnpow  路  6Comments
hland picture hland  路  3Comments
joshuamcginnis picture joshuamcginnis  路  8Comments
vahdani picture vahdani  路  5Comments
Joe-Heffer-Shef picture Joe-Heffer-Shef  路  4Comments