Flow: Integer overflow in DataCommunicator.fetchFromProvider()

[mvysny]

Flow-data 4.0.0.beta1; if Integer.MAX_VALUE is passed in as the value for limit, the pages computation overflows and will compute the value of -42949672 which will leave query null, leading to assertion failure at 757

[mvysny]

[mshabarov]

Thank you, @mvysny . A page number calculation formula will be updates so as to avoid an integer overflow:
final int pages = (limit - 1) / pageSize + 1;

[jensgoe]

Please have a look at my comment https://github.com/vaadin/flow/commit/5cd56f6dac769067e3ce1522370e263f81949860#r42617680

[pleku]

Hi @jensgoe, in which component does this occur with ?

EDIT: I'm going to guess it is MultiSelectComboBox

[jensgoe]

Yes, thats right. MultiSelectComboBox. Maybe that component needs to pass the pageSize?

[pleku]

Yes as we don't require components to do that by having it as a constructor parameter, we should just have a default value for it. I've created an issue for this and we'll fix it https://github.com/vaadin/flow/issues/9051