Flow-for-vscode: Allow for multi-root workspaces

[esbenp]

Hi there!

I have seen a few related issues (#201 #302 etc) on the lack of multi-root support and I was wondering if there was any active development going on about this? This is not to complain but I thought it would be nice to have an umbrella issue that people can subscribe to in regards to updates about this feature.

I am open to work on this a bit but I am not super familiar with this project's code base. Are there any maintainers that can point to if anyone is actively working on this, now that LSP support is default? And are there any concerns or gotchas that are preventing this from happening?

Here are some related documents:

• Adopting Multi Root Workspace APIs
• LSP Server example
• Basic example

[Mayank1791989]

I was wondering if there was any active development going on about this

Yes but it's not pushed. Most of the implementation is done and will be added soon. Also, can you share some sample repo for your use case. I want to make sure we cover all common use cases.

I thought it would be nice to have an umbrella issue

There is already #243 issue but it's very old and contains other feature also. We can keep this issue open and use it for tracking this feature.

[esbenp]

I cannot share my repos but I can definitely describe it: what I have is workspace with multiple projects: some are not in JS, some use flow version A, some dont use flow, some use flow version B. All my flowconfigs are in the root of the project. So something like this

Workspace

/projectA         <--- javascript project with flow version X.X
   /src               <--- all files are in here
   /.flowconfig  <--- flow config relevant to projectA

/projectB         <--- javascript project with flow version Y.Y
   /src               <--- all files are in here
   /.flowconfig  <--- flow config relevant to projectB

/projectC         <--- javascript project without flow
   /src               <--- all files are in here

/projectD         <--- non-javascript project 
   /src               <--- all files are in here

Does that make sense? So when switching from project A to project C, flow should be disabled. And when switching from project B to A (or vice versa) the flow version and config should change as well

[Mayank1791989]

Thanks for sharing. Your case is already handled.

[esbenp]

Amazing. Thanks @Mayank1791989 - looking forward to try it out :-)

[albertywu]

I can’t wait to try this out as well. This is the one thing blocking me from enabling workspaces in VSCode.

[FezVrasta]

@Mayank1791989 will it also support cases where the project is using Lerna or Yarn Workspaces?

packages/
  pkg1/
    /src
    .flowconfig
  pkg2/
    /src
    .flowconfig
  pkg/
    /src
    # no .flowconfig

[Mayank1791989]

@FezVrasta Basically in the new implementation I create (lazily) one client per flowconfig and manages them. So, If flow works in your use case then this plugin will support it. I am going to open PR this weekend so please share some GitHub sample repo, I will test this plugin against it.

[FezVrasta]

Thanks for the reply, unfortunately I don't think I'll be able to publish anything, but I'll make sure to test it once released.

[lloiser]

@Mayank1791989 do you have an ETA? If you create a PR I would try it out :)

[simondevries]

Excited to see this feature is nearly ready! Something that will come in very handy for me and my team

[gupta-kartik]

+1 to this getting merged!

[Mayank1791989]

fixed in v1.1.0