Flood: Not deleting files when removing a torrent

[angristan]

Hello,

when I remove a torrent and tick "delete data", it does not actually delete the files.

Is it a bug or is it on my side ?

[angristan]

It appears to be random, I'll update if it happens again

[angristan]

Still happens.

[jfurrow]

@Angristan I've noticed this also, sometimes the d.base_path= response from rTorrent is an empty string, which is what Flood uses to determine the path of the torrent. I need to figure out why this happens.

[wopian]

From what i've noticed from my current usage, torrents manually added via Flood (only tested with magnets) will have their files correctly removed when deleted.

Files added via RSS within Flood will not have their files removed when deleted. Both go to the same download directory.

Edit: Manually added torrents were all above 1.5gb, torrents via RSS have all been under 500mb.

[blackjelly]

I encountered the same problem. All the downloads are manually added by the file, prompted to delete the success, but the file still exists.

[jfurrow]

Thanks @wopian and @blackjelly for the details. That is an interesting quirk. This is the next issue I'll work on.

[jfurrow]

Thanks for your patience, everyone. I am fairly certain this is fixed, but please re-open if you run into this issue again.

[wopian]

git pulled and restarted flood. deleted several torrents added via RSS and their files remained in the downloads directory with a success message. 😧

Flood: /opt/flood
rTorrent: /opt/rtorrent/download

[jfurrow]

@wopian Thanks for the prompt update. Would you mind helping me by checking out the branch bug/fix-torrent-data-deletion-debug, then trying the same thing and providing the output from the Node server here? It should output the paths it's trying to delete. Sorry, this is crude, but I'm struggling to reproduce this.

To checkout the branch, run git checkout bug/fix-torrent-data-deletion-debug. Then restart the Flood server.

[wopian]

@jfurrow unfortunately I got neither of the 3 possible logs.

[jfurrow]

@wopian I just pushed another commit, could you git pull and try again? Thanks for your help... something is definitely awry.

[wopian]

Actually, it was my own mistake 😢. I run Flood behind screen, so was only looking at the browser's console output. Turns out it was only logging to the terminal's console.

Got the following output without file being deleted:

Should delete data: true
Selected hashes: 70CBCD1957BFECF4BBB9A5C8460A5B793EC8AF61
Attempting to delete file: /opt/rtorrent/download/[HorribleSubs] Koro-sensei Quest! - 12 [480p].mkv

[jfurrow]

Alright, we're getting somewhere... I pushed yet another commit, would you mind repeating the process?

[wopian]

Should delete data: true
Selected hashes: 70CBCD1957BFECF4BBB9A5C8460A5B793EC8AF61
Attempting to delete file: /opt/rtorrent/download/[HorribleSubs] Koro-sensei Quest! - 12 [480p].mkv
POST /api/client/torrents/delete 200 47.903 ms - 5
Deleted files:

GET ...

File still existed

[jfurrow]

Does the user account running the Flood process have access to this directory?

[jfurrow]

I pushed another commit... could you please repeat? Thanks again, I really appreciate the help.

[wopian]

Does the user account running the Flood process have access to this directory?

Mhmm. Thought I had both users under the same group. Only rtorrent user had permissions for the folder. Both are now in the same group which has read/write permissions on /opt/rtorrent/download and all files within - unless I messed that up?

...although I get the same output in the end 😭😭

Should delete data: true
Selected hashes: 70CBCD1957BFECF4BBB9A5C8460A5B793EC8AF61
Files to delete:
/opt/rtorrent/download/[HorribleSubs] Koro-sensei Quest! - 12 [480p].mkv
POST /api/client/torrents/delete 200 73.870 ms - 5
Deleted files:

GET /api/client/torrents 200 20.076 ms - -

Should delete data: true
Selected hashes: 9E20E036F4D963A16F363BE31AF413EBD5805A41
Files to delete:
/opt/rtorrent/download/[orz] Sansha Sanyou 09 [Dual-Audio Patch].zip
POST /api/client/torrents/delete 200 46.784 ms - 5
Deleted files:

GET /api/client/torrents 200 17.949 ms - -

Although I don't think it was a permissions issue, as Flood was deleting files properly in the past with large files. Currently downloading a >2gb file to verify.

[jfurrow]

Alright, I've got to sign off for now, but I'll come back to this tomorrow. Thank you _so much_ for the help, I greatly appreciate it. ❤️ Sorry you're still experiencing this issue. I'll try to create an environment similar to yours tomorrow, if you can think of any more relevant details (I can't right now), please provide them.

If any other users in can reproduce the issues @wopian's experiencing, please provide any relevant details.

[wopian]

It seems it might be an issue with torrents downloaded via a specific source (RSS and "magnets" from it consistently fail to delete). Another 2 torrents from another source that was around 300 mb and 2.2 gb succeeded:

Should delete data: true
Selected hashes: 9361A867816C567927F57A253FB4312D71E246CC
Files to delete:
/opt/rtorrent/download/[Maid-chan] RADWIMPS - Kimi no Na wa. (Original Soundtrack) (FLAC)
POST /api/client/torrents/delete 200 56.202 ms - 5
Deleted files:
/opt/rtorrent/download/[Maid-chan] RADWIMPS - Kimi no Na wa. (Original Soundtrack) (FLAC)

---

Should delete data: true
Selected hashes: 5EEA6E46E78CC2E89814B7897C83388C03F9C88D
Files to delete:
/opt/rtorrent/download/Ghost.in.the.Shell.The.New.Movie.2015.JAP.1080p.BluRay.x264.AC3-JYK
POST /api/client/torrents/delete 200 152.968 ms - 5
GET /api/client/torrents 200 111.485 ms - 850
GET /api/client/torrents/taxonomy 200 18.670 ms - 248
PATCH /api/settings 200 170.989 ms - 3
Deleted files:
/opt/rtorrent/download/Ghost.in.the.Shell.The.New.Movie.2015.JAP.1080p.BluRay.x264.AC3-JYK

[jfurrow]

@wopian This should actually be fixed by https://github.com/jfurrow/flood/pull/289. Please test and let me know. Thanks!

[wopian]

@jfurrow successfully deleted all the files! 🎉🎉🎉

[jfurrow]

Thanks for all your help ❤️

[JohnFlowerful]

Gonna bump this.
Is it possible to delete the empty directories left over from the torrents?

[jfurrow]

@JohnFlowerful Created another issue for that: https://github.com/jfurrow/flood/issues/399