Floccus: Bug? "Invalid children order: To many children"

[Grunthos]

Describe the bug

Sync now results in:
Nextcloud API error: {"status":"error","data":"invalid children order: To many children"}

To Reproduce

Was working fine, now any sync produces this error.

Expected behavior
Normal sync?

Desktop (please complete the following information):

• OS: Windows 10
• Browser: Firefix
• Browser Version: 83.0
• Floccus version: 4.4.6
• Floccus sync method: nextcloud folders

Server (please complete the following information):

• OS: Lunuz
• Nextcloud version: 19.0.4
• Bookmarks app version: 3.4.9

Debug log
Tail of log is:

2020-12-15T10:44:18.171Z { reorderings: [] }
2020-12-15T10:44:21.066Z [Error: Nextcloud API error: 
{"status":"error","data":"invalid children order: To many children"}]
2020-12-15T10:44:21.066Z Syncing failed with Nextcloud API error: 
{"status":"error","data":"invalid children order: To many children"}

I do have a lot of bookmarks.

[Grunthos]

A "dangerous" sync-from-scratch fixed the problem...

[marcelklehr]

I'm sorry for the delay. I've just released v4.4.7 for firefox with a lot of new fixes, hopefully that will fix this as well. A few issues remain, but I'm confident I'll be able to tackle those soon.

[marcelklehr]

The latest patch releases in the v4.4.x series fixed this problem. Thank you for your feedback. Feel free to open a new issue if you continue to experience problems.

[C0rn3j]

Looks like it's still there (don't be confused by the screenshot, it alternates between the two errors)

Chromium Version 88.0.4324.96 (Official Build) Arch Linux (64-bit)
Bookmarks 4.0.6
Nextcloud 20.0.5
Floccus 4.4.8

2021-01-22T14:45:31.921Z (nextcloud-folders)ORDERFOLDER { id: -1,
  order: 
   [ { type: 'folder', id: 2 },
     { type: 'folder', id: 3 },
     { type: 'folder', id: 4 },
     { type: 'bookmark', id: '66;-1' },
     { type: 'bookmark', id: undefined },
     { type: 'bookmark', id: '195;-1' },
     { type: 'bookmark', id: '75;-1' },
     { type: 'bookmark', id: '117;-1' },
     { type: 'bookmark', id: '99;-1' },
     { type: 'bookmark', id: '100;-1' },
     { type: 'bookmark', id: '101;-1' },
     { type: 'bookmark', id: '115;-1' },
     { type: 'bookmark', id: '116;-1' },
     { type: 'bookmark', id: '118;-1' },
     { type: 'bookmark', id: '119;-1' },
     { type: 'bookmark', id: '120;-1' },
     { type: 'bookmark', id: '121;-1' },
     { type: 'bookmark', id: '122;-1' },
     { type: 'bookmark', id: '123;-1' },
     { type: 'bookmark', id: '124;-1' },
     { type: 'bookmark', id: '125;-1' },
     { type: 'bookmark', id: '126;-1' },
     { type: 'bookmark', id: '127;-1' },
     { type: 'bookmark', id: '128;-1' },
     { type: 'bookmark', id: '129;-1' },
     { type: 'bookmark', id: '130;-1' },
     { type: 'bookmark', id: '131;-1' },
     { type: 'bookmark', id: '132;-1' },
     { type: 'bookmark', id: '133;-1' },
     { type: 'bookmark', id: '134;-1' },
     { type: 'bookmark', id: '135;-1' },
     { type: 'bookmark', id: '136;-1' },
     { type: 'bookmark', id: '137;-1' },
     { type: 'bookmark', id: '138;-1' },
     { type: 'bookmark', id: '139;-1' },
     { type: 'bookmark', id: '140;-1' },
     { type: 'bookmark', id: '141;-1' },
     { type: 'bookmark', id: '142;-1' },
     { type: 'bookmark', id: '143;-1' },
     { type: 'bookmark', id: '144;-1' },
     { type: 'bookmark', id: '145;-1' },
     { type: 'bookmark', id: '102;-1' },
     { type: 'bookmark', id: '146;-1' },
     { type: 'bookmark', id: '147;-1' },
     { type: 'bookmark', id: '148;-1' },
     { type: 'bookmark', id: '149;-1' },
     { type: 'bookmark', id: '150;-1' },
     { type: 'bookmark', id: '151;-1' },
     { type: 'bookmark', id: '152;-1' },
     { type: 'bookmark', id: '153;-1' },
     { type: 'bookmark', id: '154;-1' },
     { type: 'bookmark', id: '155;-1' },
     { type: 'bookmark', id: '156;-1' },
     { type: 'bookmark', id: '157;-1' },
     { type: 'bookmark', id: '158;-1' },
     { type: 'bookmark', id: '159;-1' },
     { type: 'bookmark', id: '160;-1' },
     { type: 'bookmark', id: '161;-1' },
     { type: 'bookmark', id: '162;-1' },
     { type: 'bookmark', id: '163;-1' },
     { type: 'bookmark', id: '164;-1' },
     { type: 'bookmark', id: '165;-1' },
     { type: 'bookmark', id: '166;-1' },
     { type: 'bookmark', id: '167;-1' },
     { type: 'bookmark', id: '168;-1' },
     { type: 'bookmark', id: '169;-1' },
     { type: 'bookmark', id: '170;-1' },
     { type: 'bookmark', id: '171;-1' },
     { type: 'bookmark', id: '172;-1' },
     { type: 'bookmark', id: '173;-1' },
     { type: 'bookmark', id: '174;-1' },
     { type: 'bookmark', id: '175;-1' },
     { type: 'bookmark', id: '176;-1' },
     { type: 'bookmark', id: '177;-1' },
     { type: 'bookmark', id: '178;-1' },
     { type: 'bookmark', id: '179;-1' },
     { type: 'bookmark', id: '180;-1' },
     { type: 'bookmark', id: '181;-1' },
     { type: 'bookmark', id: '182;-1' },
     { type: 'bookmark', id: '183;-1' },
     { type: 'bookmark', id: '184;-1' },
     { type: 'bookmark', id: '185;-1' },
     { type: 'bookmark', id: '186;-1' },
     { type: 'bookmark', id: '187;-1' },
     { type: 'bookmark', id: '188;-1' },
     { type: 'bookmark', id: '189;-1' },
     { type: 'bookmark', id: '190;-1' },
     { type: 'bookmark', id: '191;-1' },
     { type: 'bookmark', id: '192;-1' },
     { type: 'bookmark', id: '193;-1' },
     { type: 'bookmark', id: '194;-1' } ] }
2021-01-22T14:45:31.922Z (nextcloud-folders)ORDERFOLDER { id: 3,
  order: 
   [ { type: 'bookmark', id: '102;3' },
     { type: 'bookmark', id: '197;3' },
     { type: 'bookmark', id: '103;3' },
     { type: 'bookmark', id: '104;3' },
     { type: 'bookmark', id: '105;3' },
     { type: 'bookmark', id: '106;3' },
     { type: 'bookmark', id: '107;3' },
     { type: 'bookmark', id: '108;3' },
     { type: 'bookmark', id: '109;3' },
     { type: 'bookmark', id: '110;3' },
     { type: 'bookmark', id: '111;3' },
     { type: 'bookmark', id: '112;3' },
     { type: 'bookmark', id: '113;3' } ] }
2021-01-22T14:45:31.923Z { reorderings: [] }
2021-01-22T14:45:32.252Z [Error: Nextcloud API error: 
{"status":"error","data":"invalid children order: To many children"}]
2021-01-22T14:45:32.252Z Syncing failed with Nextcloud API error: 
{"status":"error","data":"invalid children order: To many children"}
2021-01-22T14:45:34.212Z Starting sync process for account [email protected]
2021-01-22T14:45:34.754Z Using "default" strategy

This started happening after I pulled an unnamed bookmark (Might've been literally called Unnamed or similar, don't remember) from a folder into the root and renamed it.

[marcohald]

Hi.

I also have the error invalid children order: To many children.
My Firefox Version is 85.0b9 and Floccus is on Version 4.4.8
The Nextcloud Bookmarks App is on Version 4.0.6 and Nextcloud on 20.0.5
I debugged Floccus in about:debugging the Last Request on a sync Windows does get an error Code 400 back from the Server.

This is the Content send on the Request:
{"data":[{"id":"8053","type":"folder"},{"id":"8056","type":"folder"},{"id":"8055","type":"folder"},{"id":"8057","type":"folder"},{"id":"8054","type":"folder"},{"id":"8052","type":"folder"},{"id":"8060","type":"folder"},{"id":"8058","type":"folder"},{"id":"8059","type":"folder"},{"id":"8061","type":"folder"},{"id":"8062","type":"folder"},{"id":"8986","type":"bookmark"},{"id":"8606","type":"bookmark"},{"id":"8602","type":"bookmark"},{"id":"8600","type":"bookmark"},{"id":"8601","type":"bookmark"},{"id":"8603","type":"bookmark"},{"id":"8888","type":"bookmark"},{"id":"8607","type":"bookmark"},{"id":"8610","type":"bookmark"},{"id":"8608","type":"bookmark"},{"id":"8604","type":"bookmark"},{"id":"8611","type":"bookmark"},{"id":"8605","type":"bookmark"},{"id":"8609","type":"bookmark"},{"id":"8613","type":"bookmark"},{"id":"8614","type":"bookmark"},{"id":"8618","type":"bookmark"},{"id":"8615","type":"bookmark"},{"id":"8617","type":"bookmark"},{"id":"8612","type":"bookmark"},{"id":"8616","type":"bookmark"},{"id":"8626","type":"bookmark"},{"id":"8620","type":"bookmark"},{"id":"8619","type":"bookmark"},{"id":"8621","type":"bookmark"},{"id":"8622","type":"bookmark"},{"id":"8630","type":"bookmark"},{"id":"8623","type":"bookmark"},{"id":"8632","type":"bookmark"},{"id":"8624","type":"bookmark"},{"id":"8631","type":"bookmark"},{"id":"8627","type":"bookmark"},{"id":"8625","type":"bookmark"},{"id":"8633","type":"bookmark"},{"id":"8628","type":"bookmark"},{"id":"8629","type":"bookmark"},{"id":"8635","type":"bookmark"},{"id":"8641","type":"bookmark"},{"id":"8639","type":"bookmark"},{"id":"8638","type":"bookmark"},{"id":"8637","type":"bookmark"},{"id":"8634","type":"bookmark"},{"id":"8643","type":"bookmark"},{"id":"8640","type":"bookmark"},{"id":"8636","type":"bookmark"},{"id":"8647","type":"bookmark"},{"id":"8652","type":"bookmark"},{"id":"8642","type":"bookmark"},{"id":"8649","type":"bookmark"},{"id":"8659","type":"bookmark"},{"id":"8648","type":"bookmark"},{"id":"8064","type":"folder"},{"id":"8651","type":"bookmark"},{"id":"8650","type":"bookmark"},{"id":"8653","type":"bookmark"},{"id":"8657","type":"bookmark"},{"id":"8658","type":"bookmark"},{"id":"8660","type":"bookmark"},{"id":"8656","type":"bookmark"},{"id":"8654","type":"bookmark"},{"id":"8655","type":"bookmark"},{"id":"8661","type":"bookmark"},{"id":"8663","type":"bookmark"},{"id":"8662","type":"bookmark"},{"id":"8676","type":"bookmark"},{"id":"8664","type":"bookmark"},{"id":"8675","type":"bookmark"},{"id":"8665","type":"bookmark"},{"id":"8741","type":"bookmark"},{"id":"8677","type":"bookmark"},{"id":"8065","type":"folder"},{"id":"8674","type":"bookmark"},{"id":"8680","type":"bookmark"},{"id":"8678","type":"bookmark"},{"id":"8747","type":"bookmark"},{"id":"8686","type":"bookmark"},{"id":"8717","type":"bookmark"},{"id":"8066","type":"folder"},{"id":"8067","type":"folder"},{"id":"8068","type":"folder"},{"id":"8071","type":"folder"},{"id":"8069","type":"folder"},{"id":"8070","type":"folder"},{"id":"8072","type":"folder"},{"id":"8073","type":"folder"},{"id":"8744","type":"bookmark"},{"id":"8886","type":"bookmark"},{"id":"8815","type":"bookmark"},{"id":"8076","type":"folder"},{"id":"8075","type":"folder"},{"id":"8074","type":"folder"},{"id":"8077","type":"folder"},{"id":"8078","type":"folder"},{"id":"8079","type":"folder"},{"id":"8381","type":"folder"},{"id":"8082","type":"folder"},{"id":"8081","type":"folder"},{"id":"8084","type":"folder"},{"id":"8085","type":"folder"},{"id":"8083","type":"folder"},{"id":"8086","type":"folder"},{"id":"8838","type":"bookmark"},{"id":"8836","type":"bookmark"},{"id":"8837","type":"bookmark"},{"id":"8839","type":"bookmark"},{"id":"8841","type":"bookmark"},{"id":"8840","type":"bookmark"},{"id":"8843","type":"bookmark"},{"id":"8844","type":"bookmark"},{"id":"8842","type":"bookmark"},{"id":"8868","type":"bookmark"},{"id":"8846","type":"bookmark"},{"id":"8848","type":"bookmark"},{"id":"8847","type":"bookmark"},{"id":"8845","type":"bookmark"},{"id":"8849","type":"bookmark"},{"id":"8850","type":"bookmark"},{"id":"8851","type":"bookmark"},{"id":"8855","type":"bookmark"},{"id":"8852","type":"bookmark"},{"id":"8853","type":"bookmark"},{"id":"8854","type":"bookmark"},{"id":"8080","type":"folder"},{"id":"8088","type":"folder"},{"id":"8089","type":"folder"},{"id":"8090","type":"folder"},{"id":"8091","type":"folder"},{"id":"8080","type":"folder"},{"id":"8874","type":"bookmark"},{"id":"8870","type":"bookmark"},{"id":"8873","type":"bookmark"},{"id":"8869","type":"bookmark"},{"id":"8871","type":"bookmark"},{"id":"8872","type":"bookmark"},{"id":"8878","type":"bookmark"},{"id":"8875","type":"bookmark"},{"id":"8879","type":"bookmark"},{"id":"8876","type":"bookmark"},{"id":"8885","type":"bookmark"},{"id":"8877","type":"bookmark"},{"id":"8534","type":"bookmark"},{"id":"8093","type":"folder"},{"id":"8880","type":"bookmark"},{"id":"8094","type":"folder"},{"id":"8915","type":"bookmark"},{"id":"8988","type":"bookmark"}]}

[marcohald]

I just noticed that i replied to a closed issue.
@marcelklehr Can you reopen the issue or should I create a new one ?

[marcelklehr]

I've published new versions of both floccus and bookmarks.

[marcohald]

I upgraded both.
I'm now on Version 4.08 for the Bookmarks App and 4.4.9 for Floccus.
The issue is still the same. Even the JSON send to the Server is exactly the same.

[marcelklehr]

Alright, I see the problem now, there's one folder showing up twice in the ordering.

[marcelklehr]

Can you try again with the latest version?

[marcohald]

It is now working.

[wohali]

I can confirm this has finally fixed my issues to date, in conjunction with the fixes over in #716.

Thank you @marcelklehr for all your hard work!

[marcelklehr]

Yaaay, I'm so happy it works for you now, @wohali!