Flipper: Flipper’s dependencies throw build warnings

[alloy]

🐛 Bug Report

Adding Flipper integration to one’s iOS project adds a whole bunch of build warnings.

To Reproduce

1. Create a new app:

   react-native init TestFlipper --version 0.62.0-rc.2
   open TestFlipper/iOS/TestFlipper.xcworkspace
   

2. Build (command-b)

3. See:
   

Expected Behavior

No new warnings being added to the build.

Environment

Xcode 11.3.1

[priteshrnandgaonkar]

There are few warnings from FlipperKit network plugin which I will fix it. Majority of the warnings are coming from FlipperKit's dependencies like Flipper-Folly, Flipper-PeerTalk, Flipper-RSocket, ComponentKit etc. I will fix the once coming from FlipperKit. I will fix the once coming from the dependencies later.

[alloy]

Perhaps some can be temporarily disabled with compiler flags, until you get to them? Although I believe one of them (Folly?) is mostly a header and thus warnings would have to be disabled on the targets that include it, which is going to be tougher.

[alloy]

@priteshrnandgaonkar Great stuff on getting rid of those fro FlipperKit 👌 Did you mean for this issue to be closed yet, though?

[maestor]

Is there any schedule when will dependencies warning fixed? After upgrading RN 0.62 which have Flipper support, I have massive amount of warning outputs. And my CI have 4MB of log restriction (Travis in use), so I didn't even get build finished. Reason is thousands of unnecessary warning output rows which goes over 35k lines (approximately row limit when 4MB exceed and task will terminated).

As a workaround to get builds finished, have to currently run xcodebuild with some ignore flags (CLANG_WARN_COMMA='NO' CLANG_WARN_DOCUMENTATION_COMMENTS='NO' CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF='NO').

[priteshrnandgaonkar]

Unfortunately we don't have plans yet. As most of the warnings are coming from Flipper's dependencies and not Flipper itself. If someone is willing to take it up and fix the warnings in the dependencies then that would be awesome.

[vicary]

We are piping our CI/CD logs into AWS CloudWatch for internal team notifications and these warnings increase quite a bit of expenses for log ingestion traffic, we have no choice but the ignore everything with build flags at the moment.

[caiobiodere]

having the same issue here, looking forward to have them fixed soon!