Flipper: Annotate the code with @Nonnull / @Nullable

Created on 14 Jun 2018  路  6Comments  路  Source: facebook/flipper

For better interopt with Kollin. At least the public api code should be annotated.

Android good first issue help wanted

All 6 comments

We generally don't use @NotNull internally. Unless something is marked as @Nullable, it should be considered to never be null. I believe there's a Kotlin mode/flag to enable that behaviour?

@passy indeed there is since Kotlin 1.1.4: @ParametersAreNonnullByDefault

@Takhion Nice! We should annotate the package with that.

Is anyone actively working on this issue?

Don't want to step on anyones toes but looking at a good first issue to pickup

@passy can you close this? Looks like it's already done by you :)

https://github.com/facebook/flipper/commit/0daa5de428eedd79dd23c695c861d5ae77fda011

@recheej Thanks for noting!

Was this page helpful?
0 / 5 - 0 ratings