Flex: How to handle composer dev bundles in non-dev environments?

[inverse]

I am trying to migrate an existing Symfony 4 application to flex and use the DoctrineMigrationBundle for both dev/test environments which is installed as a dev dependency.

which all looks good in my bundles.php:

    Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle::class => ['dev' => true, 'test' => true],

The problem comes when booting:

  PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "DoctrineFixturesBundle" from namespace "Doctrine\Bundle\FixturesBundle".                  
  Did you forget a "use" statement for another namespace? in /var/www/kitaspot/releases/64/src/Kernel.php:33        

Since this is a dev dependency this is stripped out when deploying to production. What's advised in this situation? Aside including it as a normal dependency.

[xabbuh]

Are you accidentally running your application in the dev or test environment while not having installed the dev dependencies?

[inverse]

This error was observed when deploying with deployer. I'm pretty sure it's running in prod.

[inverse]

@xabbuh Any ideas. It's not just this bundle. I have

    Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle::class => ['dev' => true, 'test' => true],
    Symfony\Bundle\MakerBundle\MakerBundle::class => ['dev' => true],
    Symfony\Bundle\WebProfilerBundle\WebProfilerBundle::class => ['dev' => true, 'test' => true],

All of which are required as dev composer dependencies.

[inverse]

Resolved in: https://github.com/symfony/maker-bundle/issues/151

[Gemorroj]

but not resolved for me :/

export APP_ENV=prod
./composer.phar install --no-dev

Loading composer repositories with package information
Installing dependencies from lock file
Nothing to install or update
Generating autoload files
ocramius/package-versions:  Generating version class...
ocramius/package-versions: ...done generating version class
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In AbstractRecursivePass.php line 122:
!!
!!    Invalid service "App\DataFixtures\AppFixtures": class "App\DataFixtures\App
!!    Fixtures" does not exist.
!!
!!
!!
Script @auto-scripts was called via post-install-cmd

bundles.php

return [
    Symfony\Bundle\FrameworkBundle\FrameworkBundle::class => ['all' => true],
    Symfony\Bundle\MonologBundle\MonologBundle::class => ['all' => true],
    Doctrine\Bundle\DoctrineCacheBundle\DoctrineCacheBundle::class => ['all' => true],
    Doctrine\Bundle\DoctrineBundle\DoctrineBundle::class => ['all' => true],
    Doctrine\Bundle\MigrationsBundle\DoctrineMigrationsBundle::class => ['all' => true],
    Nelmio\ApiDocBundle\NelmioApiDocBundle::class => ['all' => true],
    Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle::class => ['dev' => true, 'test' => true],
    Symfony\Bundle\MakerBundle\MakerBundle::class => ['dev' => true],
];

composer.json

{
    "type": "project",
    "license": "MIT",
    "require": {
        "php": "^7.1.3",
        "ext-iconv": "*",
        "ext-apcu": "*",
        "ext-gd": "*",
        "ext-pdo_sqlite": "*",
        "symfony/orm-pack": "*",
        "symfony/console": "^4.0",
        "symfony/flex": "^1.0",
        "symfony/framework-bundle": "^4.0",
        "symfony/lts": "^4@dev",
        "symfony/monolog-bundle": "^3.2",
        "symfony/serializer-pack": "*",
        "symfony/yaml": "^4.0",
        "symfony/dotenv": "^4.0",
        "symfony/validator": "^4.0",
        "nelmio/api-doc-bundle": "^3.2@dev",
        "imagine/imagine": "^0.7@dev"
    },
    "require-dev": {
        "doctrine/doctrine-fixtures-bundle": "^3.0",
        "symfony/var-dumper": "^4.0",
        "symfony/maker-bundle": "^1.4"
    },
    "config": {
        "preferred-install": {
            "*": "dist"
        },
        "sort-packages": true
    },
    "autoload": {
        "psr-4": {
            "App\\": "src/"
        }
    },
    "autoload-dev": {
        "psr-4": {
            "App\\Tests\\": "tests/"
        }
    },
    "replace": {
        "symfony/polyfill-iconv": "*",
        "symfony/polyfill-php71": "*",
        "symfony/polyfill-php70": "*",
        "symfony/polyfill-php56": "*"
    },
    "scripts": {
        "auto-scripts": {
            "cache:clear": "symfony-cmd",
            "assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd"
        },
        "post-install-cmd": [
            "@auto-scripts"
        ],
        "post-update-cmd": [
            "@auto-scripts"
        ]
    },
    "conflict": {
        "symfony/symfony": "*"
    },
    "extra": {
        "symfony": {
            "id": "01C0P3TPAW6JF5P0QRKQ1T7WZE",
            "allow-contrib": false
        }
    }
}

[weaverryan]

See symfony/symfony#27088

[jeroendesloovere]

I'm having the same problem when trying to deploy to Heroku (which uses "prod" environment").

My setup

composer require --dev doctrine/doctrine-fixtures-bundle

This is the error when trying to deploy using git push heroku:

// ...
remote:        Generating optimized autoload files
remote:        ocramius/package-versions:  Generating version class...
remote:        ocramius/package-versions: ...done generating version class
remote:        Executing script cache:clear [KO]
remote:         [KO]
remote:        Script cache:clear returned with error code 255
remote:        !!  PHP Fatal error:  Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "DoctrineFixturesBundle" from namespace "Doctrine\Bundle\FixturesBundle".
remote:        !!  Did you forget a "use" statement for another namespace? in /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/src/Kernel.php:32
remote:        !!  Stack trace:
remote:        !!  #0 /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/vendor/symfony/http-kernel/Kernel.php(403): App\Kernel->registerBundles()
remote:        !!  #1 /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/vendor/symfony/http-kernel/Kernel.php(122): Symfony\Component\HttpKernel\Kernel->initializeBundles()
remote:        !!  #2 /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/vendor/symfony/framework-bundle/Console/Application.php(64): Symfony\Component\HttpKernel\Kernel->boot()
remote:        !!  #3 /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/vendor/symfony/console/Application.php(143): Symfony\Bundle\FrameworkBundle\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
remote:        !!  #4 /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/ in /tmp/build_5e6efc0e7a2b34b7ab9951f4681e9656/src/Kernel.php on line 32
remote:        !!
remote:        Script @auto-scripts was called via post-install-cmd
remote:  !     Push rejected, failed to compile PHP app.
remote:
remote:  !     Push failed

And my composer.json contains

    "require": {
        "php": "^7.1.3",
        "ext-iconv": "*",
        "doctrine/doctrine-bundle": "^1.8",
        "friendsofsymfony/user-bundle": "^2.1",
        "sensio/framework-extra-bundle": "^5.1",
        "simple-bus/doctrine-orm-bridge": "^5.0",
        "simple-bus/symfony-bridge": "^5.1",
        "symfony/apache-pack": "^1.0",
        "symfony/asset": "^4.0",
        "symfony/console": "^4.0",
        "symfony/dotenv": "^4.0",
        "symfony/flex": "^1.0",
        "symfony/framework-bundle": "^4.0",
        "symfony/lts": "^4@dev",
        "symfony/orm-pack": "^1.0",
        "symfony/swiftmailer-bundle": "^3.2",
        "symfony/translation": "^4.0",
        "symfony/twig-bundle": "^4.0",
        "symfony/web-server-bundle": "^4.0",
        "symfony/webpack-encore-pack": "^1.0",
        "symfony/yaml": "^4.0"
    },
    "require-dev": {
        "doctrine/doctrine-fixtures-bundle": "^3.0",
        "friendsofphp/php-cs-fixer": "^2.10",
        "symfony/browser-kit": "^4.0",
        "symfony/phpunit-bridge": "^4.0"
    },

Solutions, anybody?

It could be solved by moving doctrine/doctrine-fixtures-bundle to require.
But I do not want it to load it in always, just for tests.

=> Does anybody know another solution?

[Pierstoval]

Yes: update your config/bundles.php and make sure the bundle is enabled only in tests & dev

[weaverryan]

@jeroendesloovere hmm. Indeed, if you look at the error, it looks like it's happening because the DoctrineFixturesBundle is being instantiated during the cache:clear - it's hitting this line: https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/src/Kernel.php#L33

When you install doctrine/doctrine-fixtures-bundle, the recipe should make sure that the bundle is only instantiated in the dev and test environments (you'll see this in config/bundles.php). My guess is that this code IS correct in your setup. I think the problem is that:

1) Heroku runs composer install
2) composer install eventually runs bin/console cache:clear

... but, for some reason, the APP_ENV environment variable during this stage is set to dev, when it needs to be set to prod. I'm not sure how this works on Heroku, but you need to make sure that at least this one env var is set to prod so that the cache:clear can run successfully in the prod mode.

[Pierstoval]

Heroku works with env vars, so you need to run heroku config:set APP_ENV=prod and run the same command for every env var. Or you can use the Settings panel on your project's dashboard.

[jeroendesloovere]

Some more information:

I believe cache:clear is not the problem

@weaverryan and @Pierstoval
We can find cache:clear in composer.json. So heroku calls this over here...

    "scripts": {
        "auto-scripts": {
            "cache:clear": "symfony-cmd",
            "assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd"
        },
        "post-install-cmd": [
            "@auto-scripts"
        ],
        "post-update-cmd": [
            "@auto-scripts"
        ]
    },

Local clearing of the cache gives no problems as you can see in the screenshots below.

src/DataFixtures using DoctrineFixturesBundle classes

Could this be the problem?

I have src/DataFixtures/* classes which use DoctrineFixturesBundle classes.
So I guess the problem has something to do with the following:
--> When running "production" environment, it tries to autowire all classes

# services.yaml
services:
    # default configuration for services in *this* file
    _defaults:
        autowire: true      # Automatically injects dependencies in your services.
        autoconfigure: true # Automatically registers your services as commands, event subscribers, etc.
        public: false       # Allows optimizing the container by removing unused services; this also means

=> But DoctrineFixturesBundle is not enabled for production environment in config.bundles.php:
Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle::class => ['dev' => true, 'test' => true],.
=> So they can not be found indeed...

Possible solution?

Ignore autowiring on DataFixtures if in production environment?

[jeroendesloovere]

I have tried some things and found the solution.

Using composer require doctrine-fixtures-bundle --dev as described in the docs was so wrong.
It needs to be composer require doctrine-fixtures-bundle.

[rsavinkov]

@inverse, @Gemorroj, @jeroendesloovere
Did you check environment variable APP_ENV on production environment? Is it "prod"?
I had same problem, and I have just fixed it.

[ChoppyThing]

Still getting the same issue for this with deployer:

Script cache:clear returned with error code 255 !! PHP Fatal error: Uncaught Symfony\Component\Debug\Exception\ClassNotFoundException: Attempted to load class "MakerBundle" from namespace "Symfony\Bundle\MakerBundle". !! Did you forget a "use" statement for another namespace? in /releases/1/src/Kernel.php:43 !! Stack trace:

I can't figure out where cache:clear is getting the dev env from. In deployer the env is correctly set to prod. For now i've added debug and the web profiler to "normal" requirements(not dev) but it's weird to have this on a production environnement.

[inverse]

@ChoppyThing did you set the app env to production for deploy?

For me I hooked in this before deploy/rollback

task('load:env-vars', function () {
    $environment = run('cat {{deploy_path}}/shared/.env');
    $dotenv = new \Symfony\Component\Dotenv\Dotenv();
    $data = $dotenv->parse($environment);
    set('env', $data);
});

[ChoppyThing]

@inverse I did. I'll try this tomorrow, thanks.