Flex-layout: Flex-layout doesn't work properly with SSR and lazy modules

Created on 12 Mar 2018 · 9Comments · Source: angular/flex-layout

Bug, feature request, or proposal:

Flex-layout adds empty stylesheets during server side rendering for lazy modules.

What is the expected behavior?

CSS shouldn't be empty.

Reproduction repo

https://github.com/atmman9001/universal-starter/ flex-layout-issue branch

What are the steps to reproduce?

pull the repo
checkout to flex-layout-issue branch
npm i
npm run build:ssr && npm run serve:ssr
Go to http://localhost:4000/lazy
Check style.flex-layout-ssr contains just {} - Example screenshot

P1 bug has pr ssr

Source

atmman9001

👍1

All 9 comments

Confirmed as an issue, likely because the lazy module is pulling in the browser providers instead of the server providers.

Will try to get a fix in this week, but @ThomasBurleson is currently away, so it might take a little longer to get it merged.

CaerusKaru on 12 Mar 2018

@CaerusKaru - Thanks for the quick reply.

atmman9001 on 12 Mar 2018

Phew glad I found this issue. This is huge since Angular best-practices is really to lazy-load every module. All of my pages therefore have a flash of improperly-styled content. Looking forward to a fix as this is sort of a big deal

stephengardner on 12 Mar 2018

@stephengardner I agree, and this is my top priority as of this morning. Unfortunately our DI setup for this library is a little muddled. As I mentioned in #373, this will be completely resolved when v6 arrives, but until then, and regardless, I'm working on a fix for 5.x

CaerusKaru on 12 Mar 2018

👍1

@CaerusKaru fantastic! Knowing it's a known issue and in-progress is all the news I need. Looking forward to it

stephengardner on 12 Mar 2018

@stephengardner @atmman9001 Ok I've got the fix working, it's in PR #659. Unfortunately, this likely won't get merged until @ThomasBurleson gets back sometime next week. If necessary you can build it from the remote branch until then

CaerusKaru on 12 Mar 2018

👍1

Thanks @CaerusKaru!

stephengardner on 13 Mar 2018

Great thanks @CaerusKaru!

atmman9001 on 13 Mar 2018

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}