Flex-layout: Layout with fxFlex="auto" not restoring max-height values properly

Created on 26 Jan 2017  路  24Comments  路  Source: angular/flex-layout

on page load scans breakpoint overlaps too aggressively [and matches the smallest instead of the largest matching].

<div fxFlex="auto" fxFlex.gt-xs="33%" fxFlex.gt-sm="50%"></div>

I'm using fxFlex with 3 breakpoints and IE seems to only pick the first one it passes:

on page load, in spite of gt-sm qualifying, it defaults to the gt-xs value. However if I manually re-size the browser it will correct itself. This happens in IE11 only.

bug

Most helpful comment

Cool. Thanks @ThomasBurleson for your work on this library. It's fantastic.

All 24 comments

Need a plunked plz

Do you have an existing plunkr I can start from?

@TylerDev6 - please update with Beta.4 (from npm) and see if the problem persists.

@TylerDev6 - Try this Starter Plunkr: https://plnkr.co/edit/h8hzyoEyqdCXmTBA7DfK?p=preview

https://plnkr.co/edit/o6zKj8?p=preview

Thanks for the help. Here's a plunk showing the problem.... I noticed a few things:

  1. It is also reproducible in Chrome / Firefox.
  2. It didn't start happening until I added fxLayoutGap properties.

Essentially, on initial page load the widths are being set to 33-33-33, instead of 50-23.4-23.4. Manually resizing the window will correct it.

I am also noticing now that going from a % based fxFlex to fxFlex="auto" does not remove the % restriction.

If you are using the code from HEAD, you should see this:

https://github.com/angular/flex-layout/blob/master/src/lib/flexbox/api/flex.ts#L264

which means the applied inline style should be flex: 1 1 auto. If not, please file a separate issue.

so I should check out @latest? I'm running beta.4 at the moment

and what's going is as follows:

fxFlex.gt-sm=33% will apply a max-width: 33% in addition to the flex 1 1 100% style.....
fxFlex="auto" will switch to flex 1 1 auto, but the max-width: 33% remains.

@TylerDev6 - please file distinct issues separately.

This is working well with the latest code in master: Plunkr Demo

-XS-
screen shot 2017-02-09 at 2 08 12 pm

-SM-
screen shot 2017-02-09 at 2 07 47 pm

-MD-
screen shot 2017-02-09 at 2 07 23 pm

I can still break your plunk.... expand to largest viewport, then refresh.... it's only on initial load of the page that it breaks.

and the "active media query" field in your plunk lists the wrong one. So I guess that's where the problem lies.

Reopening as valid issue. Thx @TylerDev6

Cool. Thanks @ThomasBurleson for your work on this library. It's fantastic.

fix_135

Fixed with #183

I moved to 2.0.0-rc.1 and can still reproduce this problem....

@TylerDev6 - When one or more mediaQueries activate (which may happen when the current viewport size is in the range of 1 or more mediaQuery ranges), the ObservableMedia will report each... and perhaps the UI only shows the last one to arrive.

Based on current code in HEAD, what specifically is the issue you are reporting ?

So when testing with the Plunk, I see that the ObservableMedia is accurately reporting the correct media query now, however the UI is still displaying the first matching result.

@TylerDev6 - Thank you.. we will investigate.

basically,

@TylerDev6 - please file a separate issue for this ^.

Closing as fixed.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_This action has been performed automatically by a bot._

Was this page helpful?
0 / 5 - 0 ratings