Flask-admin: New release?

[stiefel40k]

Hiho!

According to #1603 you were about to issue a new release which would make flask-admin compatible with sqlalchemy 1.2+. May I ask when is it going to happen? It would be nice, if I wouldn't had to patch flask-admin myself :)

Thanks in advance!

EDIT: I apologize for opening a new issue, but I wasn't sure if I should comment on an already closed issue, which I can't reopen, or open a new one...

[gordol]

Can't you just run from master? It's been merged already: https://github.com/flask-admin/flask-admin/pull/1586

[mrjoes]

The issue was closed because I pushed the new release 1.5.0 that has a fix.

[stiefel40k]

$ tail flask-admin-1.5.0/flask_admin/contrib/sqla/fields.py 

            field.populate_obj(model, None)

            self.inline_view._on_model_change(field, model, is_created)


def get_pk_from_identity(obj):
    # TODO: Remove me
    cls, key = identity_key(instance=obj)
    return u':'.join(text_type(x) for x in key)

but the 1.5.0 doesn't include the fix

I mean I still get a ValueError, and if I use the fields.py from master (nothing else patched) it works like a charm

[gordol]

Yep...

It got blown out it looks like... even though that commit is in the tree, someone else blew it out later.

[gordol]

https://github.com/flask-admin/flask-admin/commit/197896a178ca4c569cfd499ab23248730955eddc#diff-9898624cd2b7292472f2a75dd4c4db1c

"fix for python 2 compatibility" broke it again.

[stiefel40k]

And yes I can run it from master, but than why use package managers, releases and dependency management at all ;)

It kinda makes the Dokerbuild funky :)

[gordol]

Running from master wouldn't actually help in this case, someone blew out the change.

[gordol]

Actually the same author of both PRs did it. :) @asakaplan paging @asakaplan <3

[stiefel40k]

actually it works fine with py3 as well in the current master version (I tried it), cos the key is still the second in the list, so it's fine, the problem is it is not in the release

[stiefel40k]

the only thing is you have no access to the cls and the *token (whatever they are, but they don't seem to be used anyways)

[cjmayo]

https://pypi.python.org/pypi/Flask-Admin/1.5.1#downloads

[stiefel40k]

ok the arch linux package uses the git repo as source and not pip, and here it is unfortunately not shown that there was a release :( that's why the confusion

[SBillion]

I don't understand how you can run it from master. It stills broken:

https://github.com/flask-admin/flask-admin/blob/master/flask_admin/contrib/sqla/fields.py#L299

[RcrdBrt]

@stiefel40k for the archlinux pkg I switched the repo to pip, thanks for your comment on the AUR.

I'd really like that pip and GitHub releases were in sync, though.

[asakaplan]

Hi all, sorry I've been busy with a new job. I submitted the pull request originally with the * syntax and fixed it to work with py2.x after the 2.x tests failed.

Am I correct in saying that it was just a versioning issue y'all are having, or is this still an issue?

[stiefel40k]

I originally opened the issue only because of versioning, and I can tell for sure, that the fix works on py3, and I highly suspect it works on py2 as well. So no it is not an issue.

[SBillion]

@stiefel40k The fix is not in master or in 1.5.1