Flank: iOS - Preserve SkipTestIdentifiers when generating xctestrun

Created on 6 Dec 2018  路  6Comments  路  Source: Flank/flank

xctestrun file generated by Xcode includes tests in SkipTestIdetifiers section, i.e.:

<key>SkipTestIdentifiers</key>
<array>
  <string>a/b</string>
</array>

Flank incorrectly strips the SkipTestIdentifiers section.

Bug iOS

All 6 comments

+1, I have ran into this issue as well. Our current workaround is to comment out skipped tests in code instead of using SkipTestIdentifiers.

@ceaglest I should have known you would comment as soon as I sent you the link. 馃槅

But yet, this would be a super awesome fix for us.

Our current workaround is to comment out skipped tests in code

That's what we've been doing at Instructure. I'll try and get this fixed in the next Flank release.

I added a test, it looks like SkipTestIdentifiers is being preserved.

@ceaglest @paynerc Would you help me reproduce the bug by providing your xctestrun files? For bonus points, modify the JUnit test in this PR to fail.

https://github.com/TestArmada/flank/pull/434

Fixed in https://github.com/TestArmada/flank/pull/435

The snapshot jar is building now. Try it and let me know if the issue still exists.

https://github.com/TestArmada/flank/releases/tag/flank_snapshot

We are consuming 4.1.1 and it is working well for dynamically generated test cases and a sharding factor of 1.

We will try using SkipTestIdentifiers next week. Thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Sloox picture Sloox  路  3Comments

bootstraponline picture bootstraponline  路  6Comments

jrodbx picture jrodbx  路  4Comments

adamfilipow92 picture adamfilipow92  路  7Comments

bootstraponline picture bootstraponline  路  3Comments