Flank: Error when test apk has kotlin interfaces with @Test methods implementations

[thalescm]

When flank generated the shards, firebase gave a 400 saying that the test is invalid.
This gist has the complete log.

The apks (with I already sent to @renas, if anyone want to test) run successfully on my machine.

It was also a bit hard to understand what logs are from what shard. Maybe putting a common prefix to logs about what shard they're refering to could help debugging.
E.g:
https://gist.github.com/thalescm/7e64bc80fc2a32dcb8eef50fc0a96aac#file-flank-shard-error-L51-L56
all lines could start with something like SHARD X: <real log>

[bootstraponline]

@thalescm is this still happening on master? I see a fix has landed.

• https://github.com/TestArmada/flank/commit/b41a9d97267a1ea55d02bbce29c3caaae5b33983

[renas]

Thanks for reporting this. Seems like the extraction of the test name is incorrect. We use this library for that:

https://github.com/linkedin/dex-test-parser

How should the below test look like in its correct form?

class com.nu.aab_transaction_detail.test_interface.InstallmentsAmountTest$DefaultImpls#testTransactionLoads_withInstallments_correctChargesSubtitleIsDisplayed

[thalescm]

@bootstraponline it was with the master version of 1 hour before I posted the issue.

[thalescm]

@renas I think I know what the problem is. InstallmentsAmountTest is a kotlin interface.
There are some cases on the app where this behavior is present, so we extracted the test and it get tested on many different places. This way we don't have to rewrite the same test over and over.

Probably the lib does not identify that this is an interface and chooses this method to run, when it can't

[renas]

Yeah seems like it's not correctly identifying kotlin interfaces. If you can please submit this issue to the dex-test-parser project that would be great.

[thalescm]

Issue posted there.
I think it makes sense to close this issue once there's a fix there and is updated here as well. WDYT?

[bootstraponline]

Is this still an issue now that upstream is fixed?

[renas]

Will make a new release this week with the updated library.

On Sun, Aug 6, 2017 at 3:31 PM, bootstraponline [e-mail]
wrote:

Is this still an issue now that upstream is fixed?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TestArmada/flank/issues/35#issuecomment-320537209,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKGpe9Q3Fs0eMgod0FkoUDaLFTbomvWks5sVj7XgaJpZM4N4iad
.

[leandroBorgesFerreira]

Hi folks,

I'm facing this problem...

I get: Http error while creating test matrix: ResponseError 400:

When I have an interface with @Test

[bootstraponline]

Don't use @test on an interface.