Flameshot: Text annotations are not saving

[danielrosehilljlm]

Flameshot version

Installed it through the repos. Running Ubuntu 20.04. Not sure how to check the current version.

Describe the bug

When I add text, the text does not save with the other layers added to the screenshot.

Screencast demonstration:

https://www.youtube.com/watch?v=e96rp1MrS2s

To Reproduce

1. Take screenshot.

2. Add text.

3. Text does not render. I experienced this behavior both while attempting to apply other effects and while just attempting to add text to the file.

Expected behavior

System Information

Ubuntu 20.04 LTS with LXDE

[mmahmoudian]

Nice demonstration 👍 can you check the flameshot version you have:

1. Open terminal
2. flameshot --version

[danielrosehilljlm]

@mmahmoudian

Flameshot 0.6.0+git20191001-2(Debian)
Compiled with Qt 5.12.5

[mmahmoudian]

out of curiosity, can you do something else after writing the text and before pressing enter to save? For example draw an arrow. I suspect that you are still in "edit" mode and the text it not finally applied to the screenshot when you save it. If my hypothesis is correct, we can quickly fix it, otherwise it needs few more back and forth to know how it happens.

P.s. a new version will be released very very soon with some fixes and improvements. If you don't want to wait, you can compile from the Git and have the changes right away 😉

[danielrosehilljlm]

Yes!

[mmahmoudian]

@danielrosehilljlm seems my hypothesis was correct. Thanks for providing feedback.

[mmahmoudian]

@danielrosehilljlm There is a new stable version out. Would you please confirm if the issue persists in the new version as well?

[danielrosehilljlm]

@mmahmoudian Installed the new version and the issue persists. Also: when I add text but then try to copy the image to the clipboard, I cannot do so.

[mmahmoudian]

@danielrosehilljlm as one more test, if you add more than one text, would texts other than the last one get saved?

[danielrosehilljlm]

@mmahmoudian Interesting. If I add multiple layers of text, as you said, those before the last one are saved and rendered.

[borgmanJeremy]

The issue is the hot keys essential act as interrupts. When ctrl+s is hit, the program instantly save the existing image. Tools do not commit any data to the image until another tool button is pressed.

The fix is to process any in process tools before saving or copying. I think this is the behavior we want. An alternative is to only process certain tools. For example:

If you click to draw a line, and never "unclick" then hit ctrl+s should that in process line be saved? The consistent answer is yes, all tools are committed if in process.