Flameshot: Multiple displays on Windows 10

[szszoke]

Flameshot version
0.6.470.0

Describe the bug
Multiple display arrangement is not being considered which results in parts of the screenshot overlay pushed off-screen.

Main display: 27'' external screen running at 2560 x 1440, 100% scaling
Secondary display: 15'' laptop screen running at 1920 x 1080, 125% scaling

Display arrangement that does not cause the issue

Display arrangement that triggers the issue

Before pressing Print screen with the triggering display arrangement

When the bug is triggered

The saved screenshot does not seem to be affected. It seems that it's only the overlays that are drawn from the wrong origin

Clicking above the overlays (the part that is not darkened) results in the overlays being closed.

Setting both displays to 1920 x 1080 did not solve the issue.
Changing the scaling did not solve the issue.

The workaround for now is to set up a display arrangement in Display settings where the top of each display is aligned, even if they are not in real life.

To Reproduce

1. Launch flameshot.exe on a system with a multiple displays.
2. Arrange the displays in Display settings so that the tops are not aligned.
3. Press the Print screen button on the keyboard.

Expected behavior
Screenshot overlay is drawn from the top of the screens regardless of the display arrangement.

System Information
Windows 10 Pro 1903 Build 18362.778

[Tiller]

hey, it's been annoying me for a couple of month, so I just fixed it. However the project doesn't seem really alive so I doubt it will be merged.
You can found the fix at: https://github.com/lupoDharkael/flameshot/pull/742
There is a fix .exe in the description

[szszoke]

That was really quick!

Thanks!

I saw things committed in the past few days, hopefully it will get merged.

Edit: on the other hand, there are 45 open PRs..

[Martin-Eckleben]

Maybe has to do with #7
(oldest issue)

Will definitely look into this!

[borgmanJeremy]

I think this is fixed with #1126. @Tiller your PR actually did fix it so I fixed the merge conflicts and got it committed.

Sorry I missed this PR when I took over or I would have merged sooner.