Flameshot: Install in custom dir

[simonbcn]

The Makefile created doesn't allow install in a custom folder.
For example to install in /usr/ instead /usr/local/.
I'm trying to create an AUR package (_for Arch Linux_) but the actual install system doesn't allow this because I need install in a custom folder.

[lupoDharkael]

Thank you for your support creating the package. This is going to be fixed today.

[lupoDharkael]

I have it. Now you'll be able to use qmake as qmake CONFIG+=packaging to generate a makefile ready for packaging.

The changes with this option are:

• Flameshot's binary is installed in /usr/bin
• flameshot.png is installed in /usr/share/icons
• flameshot.desktop is installed in /usr/share/applications and ready to execute Flameshot from /usr/bin
• org.dharkael.Flameshot.service ready to execute Flameshot from /usr/bin

I've added a new .desktop file called flameshot-init.desktop as suggested in #10 which keeps the same pattern as flameshot.desktop about the paths when packaging.

I'll push the changes as soon as you can confirm if it is ok for packaging.

[simonbcn]

No, I'm sorry, I didn't explain it well.
For AUR packaging is necessary to simulate an installation but inside a directory that then will be packaged in order to install with pacman.
In Makefile there is a variable: DESTDIR, this variable should be used in install options before $(INSTALL_ROOT). This way I could install to another directory using make DESTDIR=/tmp install: https://www.gnu.org/prep/standards/html_node/DESTDIR.html

[lupoDharkael]

DESTDIR is where the main binary will be placed after the build process in the .pro files processed by qmake. Sadly it works different as in makefiles.
I've added a new variable called BASEDIR before every path and It can be used the same way as the DESTDIR varaible in makefiles.
I'm not an expert using .pro files but this is a decent solution. I promise I wont be breaking this setup until the 1.0 version.
I'll keep what I did yesterday (the config option) because it puts the program in /usr/ and packages should manage programs in that path and not in /usr/local (as pointed here)

That way if you want to install Flameshot in ~/myBuilds/test you would execute:
qmake CONFIG+=packaging BASEDIR=~/myBuilds/test && make install

Is this what you wanted?

[lupoDharkael]

I've pushed the changes to master. Just tell me if you find any inconveniences before I close the issue.

[simonbcn]

It works well now. I have created an AUR package for git version on Arch Linux: https://aur.archlinux.org/packages/flameshot-git/

[lupoDharkael]

Thanks! now I'm closing the issue.