Fisher: Autocomplete for rm and ls commands

[laughedelic]

I think that autocomplete for both of these commands should suggest all installed plugins (what is showed by fisher ls).

[ghost]

@laughedelic

Yeah, and that's exactly what they do. Same for fisher update :)

[laughedelic]

Then something doesn't work. They give me autocomplete for the files in current directory "/

[ghost]

@laughedelic If you create a new terminal window, you need to run fisher at least once. This is obvious from the fact fisher is self-contained. It does actually put some basic completions in your _completions_ directory, but that's about it.

[laughedelic]

Well, I got some new problems after running just fisher (see https://github.com/fisherman/fisherman/issues/242#issuecomment-217467825), but besides that, I've got autocomplete for _some_ installed plugins, except of the plugins installed from the oh-my-fish org. Even though they are all listed in fisher ls.

Also, autocomplete for the local plugins shows strange description:

ec2ls                                                       (~/.config/fisherman/ec2ls)
fish                                                         (~/.config/fisherman/fish)

(They are actually both in ~/dev/laughedelic/)

[ghost]

This one is easy to fix, we should simply follow symlinks. Thanks for reporting it. Feel free to create an issue for this too if you want, but I'll fix it right away.

Closing the original issue as invalid.

[laughedelic]

What I see in 2.6.4 is

I guess, it's not supposed to be like this

[ghost]

That only occurs when the index is not available, it's a "graceful fallback", so I guess this means you deleted it?

cat ~/.cache/fisherman/.index

[laughedelic]

Oh! I see.. After calling fisher ls-remote, I have good autocomplete.
It's so confusing and inconvenient that every time I start a new fish-shell session I have to call fisher just to get any autocompletion and then to call (at least once) fisher ls-remote to get good autocompletion... I mean, I understand why it works like this, but it's confusing and inconvenient from the user's perspective.

[laughedelic]

By the way, you can say that this good autocomplete doesn't work _"out of the box"_. Can't we have it as a plugin then? Minimal functionality out of the box and good extra autocomplete that _always_ works once installed.

[ghost]

@laughedelic Yeah, it bothers me too. I'll try an experiment and get back to you.

[ghost]

f1b676e08a5c7d2c11c4ec4e823accf32cb57408
@laughedelic Done ;)