First-contributions: Use assets from assets repository

Created on 8 Nov 2020  路  17Comments  路  Source: firstcontributions/first-contributions

With https://github.com/firstcontributions/first-contributions/issues/32256, We've moved assets we need in our tutorials to https://github.com/firstcontributions/assets. Now we should use them.

馃幆 Goal
Replace usage of assets in this repository to assets repository to reduce the size of this repo.

馃挕 Possible solutions

Following the files in which you have to change asset URLs

The change you have to make is similar to

<img style="left;" src="../assets/dt1-clonetodesktop.png" alt="clone this repository" />
猬囷笍
<img style="left;" src="https://firstcontributions.github.io/assets/gui-tool-tutorials/github-desktop-tutorial/dt1-clonetodesktop.png" alt="clone this repository" />

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. 馃帀
enhancement documentation good first issue help wanted

Most helpful comment

@DanielleInkster, yes. I've merged your pull request.

All 17 comments

Hey I'm newbie can anybody assist me

I'm desperate to learn about open source project and all related.

Can I work on this?

@omsali, would you like to work on this issue? Do you understand what are the changes we need here?

Can you tell me what you know, what you don't know and where you need help?

@fuadop, sure. Go ahead.

@Roshanjossey, thanks. I will make a PR soon.

@Roshanjossey ,Yes I would love to work on this issue.
But how would I start .
I'm known with git , a c++ programming language.

@omsali,

  1. Go through the tutorial in the Readme of this repository and learn how to create pull requests.
  2. Read the description of this issue again and try to understand it.
  3. Tell me what you understand about what needs to be done.
  4. Tell me if there is something blocking you at that point or if there's something you don't understand.

Can you do that?

@Roshanjossey
Thankyou sir.
I will try my best.

Please call me Roshan. You don't have to call anyone 'sir' here

I had a go at this. I changed the compare-and-pull and submit-pull-request from the main ReadMe and made a pull request. @Roshanjossey, can you please confirm if I've done it correctly?

@DanielleInkster, yes. I've merged your pull request.

I tried to replace 2 links. @Roshanjossey please review my PR #34955

Thanks to #34612 by @DanielleInkster, most of the asset URLs are replaced. Thank you.

I think the rest of the assets that needs to be updated are in tutorials with GUI tools.

@george-21, I see that in #34955, you worked on changing assets for a GUI tutorial. Did you have trouble finding other asset URLs?

@Roshanjossey can I work on this too?

@Roshanjossey no I did only two links just to try out the whole PR procedure since I am new in Git

@jbryan11, I've left comments on your pull request.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kevinnls picture kevinnls  路  6Comments

n0irx picture n0irx  路  5Comments

sotayamashita picture sotayamashita  路  4Comments

TomerPacific picture TomerPacific  路  11Comments

dylanbobb picture dylanbobb  路  6Comments