First-contributions: Pls add #hactoberfest2020,#hactoberfest in topics to opt-in this project for hactoberfest

[OverthinkersArea]

[Roshanjossey]

I think we shouldn't add hacktoberfest topic for this repository.

My main reasoning is that this repo doesn't comply with the rules Hacktoberfest has set for the event.
You can find it in https://hacktoberfest.digitalocean.com/details#spam

Bad repositories will be excluded. In the past, we've seen many repositories that encourage participants to make simple pull requests – such as adding their name to a file – to quickly gain a pull request toward completing Hacktoberfest. While this may be a learning tool for new contributors, it goes against one of our core values for Hacktoberfest. The quality of pull requests is paramount; quantity comes second. These repositories do not encourage quality contributions and provide an unfair advantage in completing the Hacktoberfest challenge. We've implemented a system to block these repositories, and any pull requests submitted to such repositories will not be counted.

This repository is a learning tool for new contributors.
We do encourage quality contributions and help everybody who comes here to do exactly that. Nevertheless, most pull requests we have here (going through the tutorial) can't be classified as quality contributions. It's part of a learning process.

I understand that there are contributors who have made meaningful contributions here. If there was a way to communicate that those pull requests should be counted, I'd take it. However, going through https://github.com/digitalocean/hacktoberfest/pull/596, I don't find a way to do that.

Update 5th October 2020 - https://hacktoberfest.digitalocean.com/hacktoberfest-update

Individual pull requests can also be directly opted-in to Hacktoberfest with the hacktoberfest-accepted label, on any public GitHub repository, without the need for the hacktoberfest repository topic.

We'll add hacktoberfest-accepted label to pull requests here that improves our documentation. Ping me if your pull request has to be labelled.

Update 4th October 2020:

I'm following the discussion on Re-evaluating participation rules in Hacktoberfest. Some comments that were particularly interesting for me.

https://github.com/digitalocean/hacktoberfest/issues/609#issuecomment-703177333

It has been suggested to extend opt-in to be EITHER at the repo level with the hacktoberfest topic OR at the PR level with the hacktoberfest-accepted label -- this is very much in the suggestion phase but I think this would be a simple change to the new rules that'd help with extending the reach.

https://github.com/digitalocean/hacktoberfest/issues/609#issuecomment-703225649

It has been suggested to extend opt-in to be EITHER at the repo level with the hacktoberfest topic OR at the PR level with the hacktoberfest-accepted label -- this is very much in the suggestion phase but I think this would be a simple change to the new rules that'd help with extending the reach.

This sounds like a reasonable update. I can't think of any reason why both should be required.

If they implement this change, I'd be happy to label pull requests we merge that improves our tutorial as hacktoberfest-accepted.

@sara-02, what do you think?

[sara-02]

I second with @Roshanjossey here. We should keep this repo as a learning tool and not have people use it to spam their Hacktoberfest PRs.
While documentation and translations form an integral part of this repo, and many a contributions have made that possible, I do not see a way of separately add hacktoberfest topics for some issues/PRs and not others, AFAIK that works on a repo level.

[Roshanjossey]

Thank you for sharing your thoughts @sara-02.
To be clear, I'm not worried about spam. We can dealt with that. My point is that we shouldn't participate in Hacktoberfest when we can't follow the event rules.

I do not see a way of separately add hacktoberfest topics for some issues/PRs and not others.

True. They are discussing about labels that we could apply at PR level. So that's something to hope for.

[lukeocodes]

Just my 2c. This project encourages small low-effort PRs, with steps on how to do it. As a guide, it's fantastic and great for open source.

In the context of Hacktoberfest, is it used to reach 4 PRs with low-effort. It should not add the hacktoberfest topic, for fear of it being flagged as spam to the moderators.

Translations to this project are hugely valuable contributions to the open-source community. _However, names added to CONTRIBUTORS.md probably aren't._

Projects like this are a good example of why the suggested solution of PR-specific opt-in will be a good addition to the new opt-in rules, so rather than opt-in the entire repository, you could just opt-in specific pull-requests.

[lukeocodes]

Tada 🎉

@sara-02 that update has just been released ☝️

Updated as of 10/05/2020 15:00 UTC - https://hacktoberfest.digitalocean.com/hacktoberfest-update

Individual pull requests can also be directly opted-in to Hacktoberfest with the hacktoberfest-accepted label, on any public GitHub repository, without the need for the hacktoberfest repository topic.

So now you don't need to add the hacktoberfest repository topic, but meaningful contributions to this amazing project can still count towards Hacktoberfest by using the hacktoberfest-accepted label on the PR 🎉 🎉 🎉

[sara-02]

Yes, this good news for us and the project as well.

[sara-02]

@ OverthinkersArea I hope this resolves your query, we will be moving ahead with PR based tag for this repo. And any meaningful PR(mainly other than contributors.md) will be open for evaluation :smiley:

[Roshanjossey]

@sara-02, let's keep this issue open for anybody who might have a question on how we're handling this.

[sara-02]

@Roshanjossey But we may have to clean up the pending PRs a bit so that eligible PRs are tracked on time and not missed going forward.

[Roshanjossey]

I'm trying to clean up about 70 pull requests per day. I feel burned out after that and stop. I'll try to get help.

[sara-02]

I see what is preventing from auto-merge from happening? I was under the assumption that we have that set up already.

[Roshanjossey]

Merge conflicts. @firstcontributions-bot is doing a great job at auto merging. But, it can't handle merge conflicts.

We had more than 1400 pull requests in the first six days of Hacktoberfest. https://github.com/firstcontributions/first-contributions/search?q=repo%3Afirstcontributions%2Ffirst-contributions+is%3Apr+created%3A2020-10-01..2020-10-06&type=issues

about 1000 got auto merged. I've to take care of the rest.

[sara-02]

Got it, will dig in the PRs myself, and at-least mark them, I was thinking we add a new documentation label to our documentation PRs,

[Roshanjossey]

Cool. Thank you. Yeah, go for it.

[547y4m]

@Roshanjossey excuse me sir my PR got merged today but not labelled as 'hacktober-fest' by @firstcontributions-bot. So please help me.

[Roshanjossey]

@547y4m, please call me Roshan. Bot doesn't add labels. We add it ourselves if your pull request improves our documentation. Please share a link to your pull request. I'll check.

[547y4m]

@Roshanjossey here is my PR #33928 please label it as "hacktoberfest-accepted".

[Roshanjossey]

@547y4m, I checked that pull request. The changes in that pull request is only in Contributors.md. Please read the comments above to understand how we decide on labeling hacktoberfest-accepted

[547y4m]

@Roshanjossey I didn't understand how to contribute then? I just followed the steps of Readme.md file and it's my first time participating in hacktober-fest so, please pardon me.

[Roshanjossey]

@547y4m, no worries.

Steps in the Readme is a tutorial. It helps you understand how to contribute to open source projects.
Find issues to contribute to and make necessary changes to contribute to projects. Let us know if you have any questions regarding it.

[Roshanjossey]

Now that this year's Hacktoberfest is over, I'm closing this issue.

If next year's Hacktoberfest also has same rules as now, let's reopen this issue to answer any questions that might arise then and to have discussions.

[lukeocodes]

Great job @Roshanjossey :)