First-contributions: Pull Requests aren't reflecting my changes

Created on 16 Sep 2020  路  5Comments  路  Source: firstcontributions/first-contributions

馃悶 Problem

I have followed all the steps to making a contribution

  • Forked this repo
  • Cloned it to my system
  • Created a branch
  • Added my name in contributors file
  • Committed my changes
  • Pushed the changes to my branch
  • Created a PR(Here is where the problem lies)
  • The comparison should be between the firstcontributions/firstcontributions repo and the master branch and KarenEfereyan/firstcontributions and the add-Karen-Efereyan branch which is ny forked repo. When the changes were set like this, I was unable to see the create PR button. Until I compared across KarenEfereyan/firstcontributions, master and KarenEfereyan/firstcontributions, add-Karen-Efereyan.
    It shoudn't be like that, should it?
    Because my changes aren't reflecting in the Contributors.md file

馃幆 Goal

馃挕 Possible solutions

馃搵 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for reviews in comments section of pull request.
  • Celebrate your contribution to this project. 馃帀

Most helpful comment

do i need to delete the fork of the repo entirely.

Yes, that's what I suggested please delete your fork and fork it again

All 5 comments

@KarenEfereyan, I found the problem. You created the fork before April this year. After that we did a reset to reduce the size of the repo. Because of this, the commit history of this repo and your fork is different and can't compare branches.

To solve this problem, please delete your fork and fork it again

Will that solve it or do i need to delete the fork of the repo entirely?

do i need to delete the fork of the repo entirely.

Yes, that's what I suggested please delete your fork and fork it again

Will do just that @Roshanjossey thank you

I've created #30831 to collect common problems.

Closing this issue in favor of that one.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

syakubov picture syakubov  路  5Comments

cryptographicfool picture cryptographicfool  路  12Comments

kevinnls picture kevinnls  路  9Comments

Roshanjossey picture Roshanjossey  路  13Comments

adityaprakash-bobby picture adityaprakash-bobby  路  14Comments