First-contributions: Broken link in the translation to pirate english

[lkreimann]

In the translation to pirate english I found a link to the Translations.md which isn't set correctly (current destination throws status 404).

🐞 Problem
The file README.en-pirate.md has a broken link to Translations.md (both files are located in the translations folder) - the file is linked with a relative link in markdown and points to https://github.com/firstcontributions/first-contributions/blob/master/Translations.md instead off https://github.com/firstcontributions/first-contributions/blob/master/translations/Translations.md (the last one is the correct one)

🎯 Goal
Have the Translations.md file properly linked in README.en-pirate.md.

💡 Possible solutions
I would use a absolute link here, but other relative linking is absolutely ok as long as it's done right 👍 I guess it would work if someone would just remove the ../ in the link, but I'm not sure if Markdown linking works similar to linking files in HTML.

📋 Steps to solve the problem

• Comment below about what you've started working on.
• Add, commit, push your changes.
• Submit a pull request and add this in comments - Addresses #<put issue number here>
• Ask for a review in comments section of pull request.
• Celebrate your contribution to this project. 🎉

[Roshanjossey]

Thank you for raising this issue @lkreimann.

I'd suggest to remove link to Translations.md and links to other translations (flag list) from this translation.

In my opinion, links to other translation is relevant only in the main Readme.

When you look at this from a user experience perspective, users to go translations to read the tutorial in their preferred language. Hence, there is no point in having links to other translations there.

I'd love to hear your thoughts on this.

[ankur54]

Is this issue fixed?

[Roshanjossey]

@ankur54, no, it's not. Still I'd like to know @lkreimann's thoughts on this before taking the next step

[ankur54]

Is anyone already looking into it?

[lkreimann]

@Roshanjossey I guess it's not really necessary to link to Translations.md. In the spanish translation (for example) is no link to any other language or the file metioned above - and I guess that's ok too 👍

So I would go with your suggestion and remove all the links like that, like you said.

[Roshanjossey]

Cool @lkreimann, @ankur54 would you like to proceed with making the changes suggested?

[arghyaiitb]

@Roshanjossey If no-one is picking up this then I would like to pickup this PR.

[lkreimann]

@arghyaiitb Go for it! But check the PRs first please :) Maybe there's anyone who already fixed that, who just forget to mention the number of the issue in the PR.

[Busterz]

Is this issue closed? I am assuming it is fixed because all the links work fine for me.

[lkreimann]

@Busterz try this one:

No commits to this file in the last 13 days, no PR mentioned this issue - so I guess it's still open, but @umbeebmu seems to work on this, he just needs to start a PR.

[umbeebmu]

link is still broken because my commit has not been merged yet
(not sure what I should do do have it reviewed and merged)