We should split disable-mnt into two different directives (disable-mnt and disable-media) to make things more granular.
chiraag-nataraj
All 6 comments
Alternate proposal by @smitsohu: Turn disable-mnt into a set of ordinary blacklist commands, which can be overridden as usual with noblacklist.
chiraag-nataraj
on 9 Oct 2018
Adding some advertisement for my own proposal: I doesn't change the meaning of an existing option and hence doesn't create a need to update existing profiles.
Also I recall people actually trying to noblacklist /media or /mnt in order to get their setup running, and posting to the bug tracker because that didn't work.
smitsohu
on 9 Oct 2018
We have disable-mnt in firetools GUI. Replacing it with blacklists in profile files should be fine.
startx2017
on 10 Oct 2018
@smitsohu Would disable-mnt just blacklist /mnt as a whole?
Fred-Barclay
on 10 Oct 2018
@Fred-Barclay Like it does currently, yes.
smitsohu
on 10 Oct 2018
I think splitting disable-media will only add maintenance burden as there will be yet another option to add to each profile. Changing it behavior to work as --blacklist=/media --blacklist=/run/media --blacklist=/mnt which will be overridable by --noblacklist sounds much better.
Vincent43
on 10 Oct 2018
Related issues
SkewedZeppelin
路
3Comments
ghost
路
3Comments
ericschdt
路
3Comments
polyzen
路
4Comments
reinerh
路
3Comments
Most helpful comment
I think splitting
disable-mediawill only add maintenance burden as there will be yet another option to add to each profile. Changing it behavior to work as--blacklist=/media--blacklist=/run/media--blacklist=/mntwhich will be overridable by--noblacklistsounds much better.