Firebaseui-android: FacebookSDK.setWebDialogTheme(...) method moved in Facebook SDK 4.27.0

Created on 29 Sep 2017  Â·  11Comments  Â·  Source: firebase/FirebaseUI-Android

The setWebDialogTheme(...) method has been moved from FacebookSDK to WebDialog in version 4.27.0 of the Facebook SDK (see https://developers.facebook.com/docs/android/change-log-4x/), and this makes FirebaseUI crash because this method is used in FacebookProvider.

The FacebookProvider class should be updated to use the new API.

Most helpful comment

@samtstern thanks a lot :) One question though, the initial recommendation and what you have added to docs now both worked for me:

  • compile('com.facebook.android:facebook-login:4.27.0') this works
  • compile('com.facebook.android:facebook-android-sdk:4.27.0') this also works

Any difference we should be aware, is one more correct than the other?

All 11 comments

I just realized that this was fixed in branch version-3.0.0-dev so closing this issue.

i am using version 3.0.0 and it;s not working showing error...

java.lang.NoClassDefFoundError: Failed resolution of: Lcom/facebook/WebDialog;
at com.firebase.ui.auth.provider.FacebookProvider.(FacebookProvider.java:67)

@yash59 Upgrade your Facebook dependency from facebook-android-sdk:x to facebook-login:4.27.0.

@samtstern We should probably mention in the release notes that v3.0 requires Facebook v4.27.

@SUPERCILEX will add to release notes

Hello
Can you please add this in some part of the docs please

This is the line for the Facebook dependency working for me:

compile('com.facebook.android:facebook-login:4.27.0')

Thanks :)

I just updated auth/README.md to reflect the 4.27 verison

On Wed, Oct 11, 2017 at 11:16 AM Erick Navarro notifications@github.com
wrote:

Hello
Can you please add this in some part of the docs please
Thanks :)

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/firebase/FirebaseUI-Android/issues/933#issuecomment-335900812,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIEw6hmMKc6aiI8YEFqwzKkHpTXM-i9fks5srQX8gaJpZM4PoXLI
.

@samtstern thanks a lot :) One question though, the initial recommendation and what you have added to docs now both worked for me:

  • compile('com.facebook.android:facebook-login:4.27.0') this works
  • compile('com.facebook.android:facebook-android-sdk:4.27.0') this also works

Any difference we should be aware, is one more correct than the other?

@samtstern sorry if I'm spamming here but maybe I found something, according to the docs suggested initially, Facebook move the SDK to separate modules. So it will be less heavy to add only the Facebook login module, however, I'm not sure if the ui library is doing something else.

I recently had to implement some Google login with custom permissions, which is out of the scope of this library, so I didn't use it. Maybe the same logic could be applied here. If the login is the only thing is needed then just the Facebook login library, but if there is anything else needed by the developer, then the developer is whom should customize it.

@cutiko Yep, see #967

@SUPERCILEX thanks for the clarification, and again, sorry if I was too anxious

@cutiko NP, you could have used facebook-android-sdk, but it includes a bunch of unnecessary stuff and would have bloated your APK. facebook-login is actually reasonably small compared to the whole thing.

Was this page helpful?
0 / 5 - 0 ratings