Firebase-js-sdk: Breaking TypeScript definition changes in SemVer patch (4.8.1) release

[colinskow]

It appears that between 4.8.0 and 4.8.1 you did some major refactoring which affects the import of TypeScript definitions. The most common error is Cannot find namespace 'firebase'.

See: https://github.com/angular/angularfire2/issues/1387

This should ideally be done at a SemVer major release since basically everyone who imports TS definitions from Firebase now needs to refactor the imports because the build is broken. At bare minimum it should be a SemVer minor release so that ~4.8.0 will prevent builds from breaking.

Feel free to close this issue but I just wanted to point out the impact of the changes to developers. Many TypeScript projects aren't SemVer compliant and I think it benefits the community quite a bit when they are.

[google-oss-bot]

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

[google-oss-bot]

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

[LostOnEast]

Same problem, I find it when read this tutorial
https://github.com/angular/angularfire2/blob/master/docs/install-and-setup.md
solved by downgrading firebase to 4.8.0 in my package.json

[jshcrowthe]

Hey @colinskow thanks for the issue and we appreciate your patience 😄 .

We're going to rollback the part of the typings refactor exposed by the NPM firebase package which should fix this issue (see #401). Thanks so much for your help!