Firebase-android-sdk: R8 configuration in Firebase Crashlytics

[quiro91]

What feature would you like to see?

Looking at the official guide, it's recommended to add the following configuration for "faster, obfuscated build with ProGuard".

-keep class com.google.firebase.crashlytics.** { *; }
-dontwarn com.google.firebase.crashlytics.**

Is this required also for R8? If yes, could it be bundled with the SDK?

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[ashwinraghav]

Thanks for pointing that out. Seems like we should be able to add these to the SDK

[quiro91]

Before adding it, are those actually required? I was testing it before and
it looks like everything works fine without those rules

On Mon, 01 Jun 2020, 16:59 Ashwin Raghav, [e-mail] wrote:

Thanks for pointing that out. Seems like we should be able to add these to
the SDK

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/firebase/firebase-android-sdk/issues/1607#issuecomment-636940919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKFB4GSD2AYVYHGAMIKSODRUPF7JANCNFSM4NPWF3LA
.

[mrwillis21]

Hi @quiro91 - we've had these as part of the Crashlytics SDK docs for a long time, and it's definitely worth asking the question of whether they're still relevant! I'll raise this up to the team and see how we can best clean this up. Thanks!

[mrwillis21]

Hi folks - this has been cleaned up, and should be reflected in the official docs soon. Thanks for the report!