Firacode: .- ligature looks strange in the middle of words

[michaelkuhn]

In German, we really like hyphenated words. They sometimes also contain periods because they contain abbreviations or numbers, which looks strange (see attached screenshot taken with Fira Code 5.2).

Would it make sense to only enable the .- ligature if it is surrounded by whitespace?

[tonsky]

Space won’t work, but it was originally intended for Clojure. Maybe it’s not worth keeping—looks strange anyways

[tomyun]

FYI, it also kinda conflicts with Julia where .- indicates minus operator with syntactic loop fusion.

[clason]

I don't know how much work this is, but would it be a compromise to turn this ligature into a stylistic set? (Since, at least anecdotally, it seems to be annoying in more situations than it is useful, it's probably better disabled by default, but either choice would be a strict improvement.)

[RubenVerg]

In scala, there are no operators. All "operators" are just functions that use inline operator syntax, so a.fn(b) becomes a fn b. 3 - 3 can be written as 3.-(3). If the ligature applies, and it becomes 3·-(3), it's hard to read.

[pjentsch0]

FWIW I like it in Julia

[clason]

@pjentsch0 Really? Doesn't it bug you that it's only for .- (and .=), so a .= α.*b .+ c .- d is not consistent?

(What would be perfect would be a stylistic set that aligned . + 'operator' consistently, but how would you choose which operators to include?)

[pjentsch0]

@clason It does, and I agree that a set is better, but I'd prefer to only have a ligature for .- than no ligatures.

Could we not align . and +-=/ ? Of course you can broadcast almost anything in Julia, but I think that covers a lot of the common use cases. Usually I use the @. macro for long broadcast chains.

I'm not sure what a stylistic set is, I assume it's like a set of ligatures that can be enabled/disabled?

[clason]

@clason It does, and I agree that a set is better, but I'd prefer to only have a ligature for .- than no ligatures.

Interesting.

Could we not align . and +-=/ ?

That would be a reasonable default, yes, but I'd add *.

Usually I use the @. macro for long broadcast chains.

That works (unless there are enough operations that are _not_ supposed to be broadcasted (but that is getting beside the point here).

I'm not sure what a stylistic set is, I assume it's like a set of ligatures that can be enabled/disabled?

https://github.com/tonsky/FiraCode/wiki/How-to-enable-stylistic-sets

[pjentsch0]

That would be a reasonable default, yes, but I'd add *.

Definitely, I forgot that one.

https://github.com/tonsky/FiraCode/wiki/How-to-enable-stylistic-sets

cool, thanks

[eins78]

Another (real-world) example: MwSt.-Nr.

[tonsky]

Will be disabled in v6 by default. Linked: #860