Firacode: Disable Elvis ligature (?:) for optional TypeScript properties

[Peeja]

I don't know languages where ?: is used as an operator well, but in TypeScript the sequence comes up a lot in interfaces, denoting optional properties in an interface:

The two characters don't form an operator here, they just happen to be next to each other, so the ligature is odd. Is ?: always (or at least usually) surrounded by spaces when it's used as an operator? Maybe it would work to only apply the ligature to :?, with the preceding space? (I don't have much experience with ligatures like this, so I have no idea if I'm asking for something reasonable.)

[tonsky]

Interesting! I’ll mark it as a conflict but I’m not sure what can I do, except removing ligature altogether

[jdreesen]

It's used as ternary if operator in PHP. Spaces are not required.

[Peeja]

@jdreesen Wouldn't that be foo ? bar : baz? That's not going to use the ?: ligature.

[j-f1]

I know some languages (C?) use a ?: b as shorthand for a ? a : b or how a || b works in some languages.

[jdreesen]

@jdreesen Wouldn't that be foo ? bar : baz? That's not going to use the ?: ligature.

Right, but you can do $foo ?: $baz as shorthand, which returns $foo if $foo evaluates to true, and $baz otherwise. Example: https://3v4l.org/8H95j

[BenLeggiero]

Sad to see this go (I use it a lot in Kotlin, ObjC, and others), but I understand why it did

[a-p-o]

Kotlin uses ?: (elvis operator). It is conventionally surrounded by spaces. This is an unfortunate change for Kotlin users 😢