Firacode: Make pipe | shorter

[tonsky]

Thanks for the good work. But in my personal opinion, the new | seems too tall in normal code. Now the || is way taller than &&, which seems inconsistent. Also, some related ligatures is inconsistent to this taller |, like |=

---

EDIT: I'm talking about the ASCII symbol | (U+007C) instead of the BOX DRAWINGS LIGHT VERTICAL │ (U+2502). In v2.0, the | (U+007C) becomes taller, which I think is a mistake.

_Originally posted by @blahgeek in https://github.com/tonsky/FiraCode/issues/449#issuecomment-531531138_

[tonsky]

It became taller to match full block height in progressbar:

     |████████████████████████████████| 102kB 4.6MB/s 

Maybe it’s not such a good idea.

[tonsky]

Actually now I’m thinking that I can detect that specific case and alter the height in that case only

[blahgeek]

I think a proper progress bar should use U+2502 instead of U+007C anyway

[tonsky]

Tell that to pip authors :)

[j-f1]

Actually now I’m thinking that I can detect that specific case and alter the height in that case only

What about when the bar isn’t all the way full?

 |████████████████████████        | 102kB 4.6MB/s

[tonsky]

Yeah, bad idea. Shame :(

[JakobBruenker]

I actually quite liked it last time I used a font with vertical bars this long, specifically for haskell's guards, and I like it here as well:

(github file attachment doesn't seem to work for me at the moment, so here's an imgur link)
https://i.imgur.com/KxQWNOU.png

If you end up removing it, maybe consider leaving it in as a stylistic set, I would appreciate it.

[tonsky]

Looks great in your screenshot. Thanks for that use-case!

[carlsmith]

Another vote for keeping the bar full-height.

[rumpelsepp]

htop is a bit hard to read with these long pipes:

vs. Hack

edit: I have a 4k monitor. The gap between the bars disappears with lower resolutions.