Firacode: Please add #!/, (), and }) ligs

[easyaspi314]

#!/ is used in shell scripts, like:

#!/system/bin/sh
echo "Hello, world!"

() and )} is used in many languages as well, such as after a Java interface override. Both are used commonly, especially (). This one should be a given, especially since we have a box for [].

myButton.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        FragmentManager manager = getActivity().getFragmentManager();
        FragmentTransaction transaction = manager.beginTransaction();
        MyFragment myFragment = MyFragment.newInstance();
        myFragment.setArguments(getActivity().getIntent().getExtras());
        transaction = transaction.replace(android.R.id.content, myFragment);
        transaction.commit();
    }
});

In Fira Code:

[easyaspi314]

@tonsky how about this for an idea?

[tonsky]

@easyaspi314 Not sure about that. Don’t like uneven spacing, and you would never guess all the contexts where this combination might pop up

[easyaspi314]

Well what about the ); ?
On Apr 13, 2016 11:38 AM, "Nikita Prokopov" [email protected]
wrote:

@easyaspi314 https://github.com/easyaspi314 Not sure about that. Don’t
like uneven spacing, and you would never guess all the contexts where this
combination might pop up

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/tonsky/FiraCode/issues/169#issuecomment-209515847

[tonsky]

I can tune the spacing, but I don’t see it as an improvement. You see, idea
of Fira Code was to make sequences that are one logical operator look like
one symbol. In this case, semicolon and closing paren are not part of the
same sequence. In fact, they’re part of different constructs. I don’t think
I should move them closer together.

On Wed, Apr 13, 2016 at 9:40 PM easyaspi314 (Devin) <
[email protected]> wrote:

Well what about the ); ?
On Apr 13, 2016 11:38 AM, "Nikita Prokopov" [email protected]
wrote:

@easyaspi314 https://github.com/easyaspi314 Not sure about that. Don’t
like uneven spacing, and you would never guess all the contexts where
this
combination might pop up

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/tonsky/FiraCode/issues/169#issuecomment-209515847

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
https://github.com/tonsky/FiraCode/issues/169#issuecomment-209516774

[easyaspi314]

OK. Do you think you can do anything with #! and #!/?

[tonsky]

! makes sense, yes. But slash in #!/ is, again, not part of that logical

sequence

On Wed, Apr 13, 2016, 22:12 easyaspi314 (Devin) [email protected]
wrote:

OK. Do you think you can do anything with #! and #!/?

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
https://github.com/tonsky/FiraCode/issues/169#issuecomment-209527113

[easyaspi314]

OK.