Filterlists: Update some AdGuard filters' names.

Created on 13 Apr 2019  Ā·  8Comments  Ā·  Source: collinbarrett/FilterLists

AdGuard English Filter
-> AdGuard Base Filter

AdGuard Spyware Filter
-> AdGuard Tracking Protection Filter

AdGuard Useful Ads Filter
-> AdGuard Filter unblocking search ads and self-promotion

directory-data

All 8 comments

These names are not universal. They exist and are ā€œupdatedā€ / changed from their original names that are still in use. If AdGuard wishes to change the names of their filters so that they conflict with what they are named right here on GitHub, then by all means Andrey has the right to do so. However, as an individual who does not represent AdGuard in any way whatsoever, @lancelot-moon Unless you were sent here on request by any of the AdGuard devs with sufficient rights to do so, I do not feel this is an appropriate issue. Nor do I think this is, for lack of a better phrase, ā€˜Good GitHub Behaviourā€.
BA59E7B8-EB02-41B4-98CF-EF1AD30224BA
A065EFF1-FF27-4C62-93CD-8CFAB4BC3BC6

@existential-fallacy You are not right.
You have a folder with English filters on the screenshot. All these files are collected in 1. And this file is called (in the header) AdGuard Base Filter

@lancelot-moon I'll do PR now

@existential-fallacy
AdGuard early renamed these filters.
Just you don't know because you may not use AdGuard products.
Try its free AG Browser Extension.
https://chrome.google.com/webstore/detail/adguard-adblocker/bgnkhhnnamicmpeenaelnjfhikgbkllg?hl=en-us

AdGuard team only don't update its KB yet.
They're always busy so that they forgot to modify them.
https://github.com/AdguardTeam/AdguardKnowledgeBase/issues/307

Screenshots:

image

image

image


@bogachenko If you’d kindly direct me to the _Repository_ - not the software for any platform - that labels it as AdGuard Base Filter, I’d appreciate it just for my own enlightenment. ā€œJust screenshotsā€ were just taken and here’s another with EST up top. āœŒšŸ¼
F5FDDF94-52B1-4117-8A46-33809B6A9521

Edit: Would it not be more appropriate to have Andrey personally submit an issue or pull request as they, in the end, belong to him and the AdGuard team as a whole? That’s ultimate point here My issue is with a non-affiliated person requesting the change.

Absolutely you're not an AdGuard user.
Those filters were early renamed in every AdGuard product.

Press, pull down and then release on the filters section's screen of AG for iOS.

Those filters information will be sync and updated with AdGuard server.

@existential-fallacy
After I mentioned, Andrey assigned TheHasagi to modify the filters' names on KB.
Just AdGuard team are busy in fixing AdGuard apps' bugs.

You should shut up because you may be even not an AdGuard user.

@existential-fallacy
After I mentioned, Andrey assigned TheHasagi to modify the filters' names on KB.
Just AdGuard team are busy in fixing AdGuard apps' bugs.

You should shut up because you may be even not an AdGuard user.

Hostile as usual. I’m out. I don’t need that sort of energy. Especially polluting a love of mine. Goodnight all.

Such an ignorant guy and always don't admit your mistake.
Officially, AdGuard had modified those filters' names.
https://github.com/AdguardTeam/FiltersRegistry/issues/159

Was this page helpful?
0 / 5 - 0 ratings

Related issues

3xploiton3 picture 3xploiton3  Ā·  5Comments

Atavic picture Atavic  Ā·  3Comments

mkb2091 picture mkb2091  Ā·  4Comments

KonoromiHimaries picture KonoromiHimaries  Ā·  5Comments

DJCrashdummy picture DJCrashdummy  Ā·  5Comments