Files: File and folder names lost their border radius

[Akryum]

In Loki, the file and folder labels had a nice border radius when selected:

Maybe it's just me, but it doesn't look good now:

[jeremypw]

This is down to 16a545eeebb2b758dda176481333fa5b5e271cc7

[Akryum]

Is it possible to use CSS to apply border radius on those?

[Akryum]

Maybe the background can be removed altogether since we have a background color on the entire item now?

[jeremypw]

I think there is a problem using CSS in a CellRenderer - you are not rendering individual widgets, so changing the CSS for the view would change every item.

Yes, the background could be removed if @elementary/ux approve.

[Akryum]

However this brings the question of the color tags. Maybe the background can safely be removed if there is no color tag. With color tag it would be better with border-radius, it looks unpolished without it.

MacOS has another solution, a color bullet in from of the label:

[jeremypw]

The bullet could be emulated if desired (if it is not patented ...).

[jeremypw]

Actually I think there is a way of putting the border radius back by adding a CSSProvider on the fly.

[cassidyjames]

The color bullet looks nice and avoids contrast issues with text, so I'm in favor of that design change. Other @elementary/ux thoughts?

[jeremypw]

I'll look into implementing this. May be tricky using CSS (suggestions?) but should be doable with Cairo

[jeremypw]

Or maybe can be rendered in the Pango layout?

[cassidyjames]

@jeremypw CSS would probably be best for flexibility down the road. We do a colored dot for calendars, maybe check that code?

[cassidyjames]

@jeremypw it looks like we add a grid with a width/height request and style class, then style it right in the code

https://github.com/elementary/calendar/blob/1da543ce2f5999183c50046fa693e4e2071e9ef6/src/Widgets/CalendarButton.vala#L218

https://github.com/elementary/calendar/blob/1da543ce2f5999183c50046fa693e4e2071e9ef6/src/Widgets/CalendarButton.vala#L20

[jeremypw]

@cassidyjames Thanks, I'll check that out, although here we are rendering a CellLayout not a Widget.