Fightpandemics: Sort posts by most recent in profile activity

[joshmorel]

Mentioned here #875 we should sort posts by most recent in profile activity pages.

@Naraujo13 we need to ignore location in this case. We talked about another parameter but I also wonder, at least for now if authorId is set then they are viewing the profile activity so in such a case ignore location. Or is this not explicit enough?

[Naraujo13]

Mentioned here #875 we should sort posts by most recent in profile activity pages.

@Naraujo13 we need to ignore location in this case. We talked about another parameter but I also wonder, at least for now if authorId is set then they are viewing the profile activity so in such a case ignore location. Or is this not explicit enough?

I would prefer having a sort parameter where we can choose the location criteria so it is more explicit.

It won't require much change in the frontend, just adding this param to the r request.

[joshmorel]

Feel free to take this on and do b/e only. I can add f/e in separate issue or with PR review.

[Naraujo13]

Ok!

[joshmorel]

@Naraujo13 hey I asked PMs in Slack and for activity we should exclude all visibility filters.

So for activity we should have some query param flag that totally ignores user location stuff (both geo sorting & visibility filters) - so a similar result to non-logged in user with no location filter.

I say we address both here

Not sure what we want to call it maybe ignoreLocation=true

[Naraujo13]

So we would ignore location, expiration and visibility filters, right?

[vikjoshi]

@indirabhowmick @joshmorel @Naraujo13 , since we're adressing the visibility filters for posts under profile, I moved this into MVP-Critical

[joshmorel]

Location & visibility definitely. I think expiration might be tricky unless, if we include these on activity we need some kind of display to clarify that the post is no longer valid.

My inclination would be for still filter out expired posts out until we decide how that information should be conveyed.

Thoughts @vikjoshi ?

[vikjoshi]

Based on Slack convo, we will just remove the filter for soft launch for expiration. I will create a new ticket to address a tag or something like that to differentiate between expired and unexpired posts- to be tackled post soft launch.

CC: @Naraujo13 @joshmorel @indirabhowmick

[Naraujo13]

Okay, but that is just for the profiles right?

At the feed we maintain the filter?

[vikjoshi]

@Naraujo13 yup exactly! This is just for what shows up on the View Profile page for Individual and Org profiles

[vikjoshi]

@joshmorel @Naraujo13 , just tested on staging and it looks like we are still seeing the issue where if the org. address is in a different city/state/country than the individual profile address, then the post does not show up under the org. profile page. It looks like this only happens when we set the post visibility to City- if post visibility is State, Country, Worldwide, the posts do show up on the org profile. Are one of you or someone else working on that?

[vikjoshi]

@Naraujo13 let @joshmorel and I know whether you are able to address my comment above- if not Josh will take this on so we can get it in prior to code freeze this week

[joshmorel]

I'll take this one on as I have bandwidth. Hope to have PR this morning.