Fightpandemics: fix layout on landing view

Created on 11 May 2020  路  12Comments  路  Source: FightPandemics/FightPandemics

flow

layout issues

1 - logo is not aligned on the left with the title (may be a navbar problem)
2 - spacing below logo
2 - missing title
3 - spacing between title and subtitle
4 - spacing on lines on subtitle
5 - no rounded borders in the blue box
6 - no left margin
7 - incorrect font styles used in the blue box

Screenshot 2020-05-11 at 03 26 37

Styles should be pixel perfect:
Screen Shot 2020-05-10 at 11 14 36 PM

iMac, Chrome

Reference:
https://www.figma.com/file/4cV84H1jyMo0rJEAl3HNnJ/FightPandemics-landing-page?node-id=1377%3A8027

Difficulty - Easy FRONTEND HomePage MVP - Release 1 bug

Most helpful comment

@TiagoaTavares Ok good to know. We actually discussed about this in the previous PR because there were conflicting designs showing different things. If I remember correctly some of the things you point out this time did not exist the last time we worked on this. I think engineers need to be better updated on design changes such as this to prevent possible regression.

All 12 comments

So the padding for the header / navigation bar has to be changed? That will change it for all pages. Just want to make sure that's alright before I start working on this!

cc @anniegiang

So the padding for the header / navigation bar has to be changed? That will change it for all pages. Just want to make sure that's alright before I start working on this!

Not sure... But for this issue specifically it looks like there's some padding/margin on the left of the blue box. Maybe we could set either of them to be 0 so that it's right next to the left side.

Ah ok so I just played with the styles in the console and removed the margin added on the right and left side of <main> (probably not a good idea since it'll affect all pages). I also removed the unnessccary rounded borders to the box:

Screen Shot 2020-05-10 at 11 16 09 PM

Hello Team,
this issue is still not complete. Please check the below image. The text is still missing:

image

Also comparing to Figma the spacing between texts is still too big:
image

Thanks,
Tiago

@TiagoaTavares Ok good to know. We actually discussed about this in the previous PR because there were conflicting designs showing different things. If I remember correctly some of the things you point out this time did not exist the last time we worked on this. I think engineers need to be better updated on design changes such as this to prevent possible regression.

Hello @anniegiang. My user would be @tiagocostasilva instead of @TiagoaTavares (this is the other Tiago :D ) but not worries
From what i see when @stavares843 oppened this issue, the things i mention here were already identified, so i think this details were missed. This should not be skipped from the MVP.

@tiagocostasilva this page is updated, its in staging now

@snowiesuet is there something missing on this issue?

@tiagocostasilva @snowiesuet is this still not fixed?

@robinv85 I believe that this is fixed with better UI. @idjevm has made the changes as per the design. We need to close it without impacting the changes @idjevm has made.

This issue seems to be fixed. Closing this for now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

adorapham picture adorapham  路  4Comments

tiagocostasilva picture tiagocostasilva  路  10Comments

rabbi08 picture rabbi08  路  6Comments

joshmorel picture joshmorel  路  7Comments

dfrancks picture dfrancks  路  10Comments