Fetch: Performance issue

[maulik9898]

I am using this library in one of my project. But there is a serious performance issue with this library.
To check is this library issue or another issue I compare the performance of this library with another library Okdownloader and Android app ADM downloader.

Here is a common configuration:

Max thread:9
Max concurrent Download:3
Active Download:3
Download URL:https://excellmedia.dl.sourceforge.net/project/xiaomi-eu-multilang-miui-roms/xiaomi.eu/MIUI-STABLE-RELEASES/MIUIv10/xiaomi.eu_multi_HMNote7Pro_V10.3.5.0.PFHCNXM_v10-9.zip

Device Info:https://valid.x86.fr/a/5lfebk

1) ADM Downloader ( CPU Usage: 25% )

2) OkDownloader Library ( CPU Usage: 24% )

3) Fetch Library ( CPU Usage: 50% )

I love this library and that's the reason I don't want to move to another library.
But this performance issue is a real pain. I hope u will look into this.

[maulik9898]

The App I develop to perform this test https://github.com/maulik9898/PerformanceTest

[maulik9898]

Here is CPU profile image from android studio.
1) Ok downloader

2) Fetch

I am no expert in this but this may be helpful to you.

[tonyofrancis]

looking into this

[maulik9898]

This problem only present in PARALLEL mode

[tonyofrancis]

@maulik9898 Thanks for reporting in detail. Made it super simple to pin point the issue. It is fixed now. It will be in the next release.

[tonyofrancis]

@maulik9898 a new version of fetch is available with this fix. see the readme and changelog.

[maulik9898]

@tonyofrancis that's awesome man.

[maulik9898]

cpu usage of fetchActivity drop from 50% to 20%-25% that's amazing

[DHosseiny]

@maulik9898 a new version of fetch is available with this fix. see the readme and changelog.

Sounds version is androidx 3.1.1. But there is no notes about it in 3.1.1 release notes.

[tonyofrancis]

@DHosseiny fixed in androidx version 3.1.2 latest. The bug has existed for a long time now. Glad @maulik9898 spotted it.