Ferdi: OS X Different Notification Icon Per Service

[billyfordon]

Is it possible to use the actual service icon in the OS X notification rather than the Ferdi icon? It is not a must-have, but definitely a very nice to have as it would make it very clear what service is sending the notification.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label enhancement to this issue, with a confidence of 0.56. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[billyfordon]

Browsing through the code, it seems like it would work simply by removing this check: https://github.com/getferdi/ferdi/blob/6999476b9eb71880e16b413f27a7df5bf458cd47/src/stores/AppStore.js#L282

I am far from being an expert on this, but is this even necessary? What was the reason for removing blobs? Do we really care if the blob gets stored on disk?

[vantezzen]

As far as I can tell, blobs cannot be used for notification icons.

The notifications constructor (https://developer.mozilla.org/en-US/docs/Web/API/Notification/icon) requires "the URL of an icon" so blob URLs are probably too scoped to the current WebView and can't be used system-wide. That's why we need to have the icon stored on disk. We may be able to use the icons from the uncompressed recipe directory (~/Library/Application Support/Ferdi/recipes) though.

[billyfordon]

Yes, I was doing some reading and it looks like that is a constraint. However, even going one step further by allowing the notification to use the contact icon (e.g., the picture of the person or group sending the message) should be possible, no? Since the web application must give you an URL or a blob for each contact to display it in the browser, we could just save it to disk and display it, no?

[vantezzen]

This requires Ferdi to know where to find the picture for each notification, which is different for each service and can be quite hard to decide depending on the service. This would also have the same problem as the current solution in that blobs would need to be transferred to disk first.

[billyfordon]

True. I know of a couple OS X apps (Rambox, One Chat) that do this, so it should not be too hard... What about an 80-20 approach? Do this for the main services (WhatsApp, Telegram, Skype, etc.) and leave the others be. Happy to contribute some code if that would be acceptable...

[iliyang]

Agreed with @billyfordon. I'm coming from Rambox and so far the only feature I miss from it is the per-service notification icon – makes it very easy to see if a notification is important (e.g. coming from the work Slack) or not (e.g. from the wife via Messenger 😇 ).

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Please check if this issue is still relevant and please close it if it's not. This will make sure that our open issues are actually of use and reduce the list of obsolete issues. Thank you for your contributions.