Ferdi: Screen sharing does not work

[Esokrates]

" are comments from us and won't be
visible in your bug report, so please don't put any text in them.
-->
Describe the bug

Using Skype in the latest Flatpak version screensharing does not work, clicking screensharing does nothing.

Desktop:

• OS: Ubuntu 20.04 (Gnome session, using X11)
• Ferdi Version 5.4.3
  

[Zackhardtoname]

Not working for Discord neither (can't share screen).
Laptop:

OS: Ubuntu 18.04
Ferdi Version 5.4.3

[kytwb]

Related to https://github.com/electron/electron/issues/4432.

[MurzNN]

Same problem with all other services, that provide screen sharing feature. Maybe this workaround https://github.com/electron/electron/issues/16513#issuecomment-602070250 can help with implementing custom screen sharing picker?

[gautamsi]

@MurzNN I came across this issue after opening a PR - https://github.com/getferdi/recipes/pull/116

It worked for Teams so should also work for skype.

[Esokrates]

@gautamsi Would you mind implementing this for Skype too?

[gautamsi]

@Esokrates I have added a PR (https://github.com/getferdi/recipes/pull/170) for this which is exactly like Teams.

[MurzNN]

@gautamsi Great thanks! Screen sharing in Skype with your patches works well! Waiting merge this PR with master!

[Esokrates]

@gautamsi Thanks very much!
@kytwb Actually this bug should remain open as there are still other services that don't have screensharing, e.g. Discord?

[MurzNN]

Maybe exists some way to integrate this feature globally in Ferdi, to work for all services? If Ferdi use iframe, here is way to pass getDisplayMedia() from iframe: https://developer.mozilla.org/en-US/docs/Web/API/Screen_Capture_API/Using_Screen_Capture#Security_2

<iframe src="https://mycode.example.net/etc" allow="display-capture">
</iframe>

[gautamsi]

I will try over weekend to see if can integrate as umbrella solution for all.

[tubbynl]

this will be awesome, thank you guys for your effort :)