Fenix: [Bug]Tab selection checkmark disappears after background/resume

[AndiAJ]

Prerequisites

Tab view should be set to Grid
Have a couple of open tabs

Steps to reproduce

1. Open the Tabs Tray
2. Long tap one of the tabs
3. Put Fenix in background and afterwards resume
4. Tap on another tab

Expected behavior

Step 3: The ✓ (checkmark symbol) should remain displayed after resume
Step 4: Both tabs should be selected and counted properly

Actual behavior

Step 3: The ✓ (checkmark symbol) disappears d after resume
Step 4: Only one tab will be displayed as selected

Device information

• Android device:
  • OnePlus A3 (Android 6.0.1)

• Fenix version:
  • Nightly 201120
  • Beta 84.0.0-beta.1

Notes

✔️ Not reproducible in List view

► Video

[shahsurajk]

@AndiAJ, can't seem to replicate this on the latest nightly 201125 17:01. Can you check once again for the same?

[AndiAJ]

Hi @shahsurajk, unfortunately it's still reproducible on the latest Nightly 201126 using a Google Pixel 3a (Android 11)

► Video

[shahsurajk]

@AndiAJ , im not sure if its the same issue. In the GIF we're looking at a rotation issue, while this issue is regarding selection of tabs and background/resume. :thinking:

[AndiAJ]

Sorry @shahsurajk , my bad, got distracted and confused it with #16681. ☺️

It's still reproducible on the latest Nightly 201126 using the following devices:
• Google Pixel 3a (Android 11)
• Huawei Mate 20 Lite (Android 10)
• OnePlus A3 (Android 6.0.1)

► Video

[eliserichards]

When testing on my device (Pixel 3, latest Nightly), I am seeing that on resuming the app we are exiting out of "select mode" altogether. ~I think this is an acceptable flow, and will follow up with UX to check.~

One of the things that I want to confirm is that, in the above comment, the app is not exiting select mode. It only seems to be un-checking the focused tab. If this is happening on all devices, then it's definitely broken 😓

[eliserichards]

~@AndiAJ would you be able to test next week with the latest nightly and see if your devices are exiting select mode like my Pixel 3? I'm wondering if it is different on other devices 🤔~

Checked with @violasong and confirmed that on Galaxys and other devices select mode is being persisted. The recommendation is to persist select mode on pause/resume (following the example of other apps with this functionality).

[eliserichards]

TabTrayDialogFragmentState.Mode.selectedItems is losing the current (last-selected) item when we're resuming. If you re-click it, it's adding it to the list again... See there's only 5 tabs, 4 of which are selected, and the list shows 8: